From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SK3FHAy6+GNibwAAbAwnHQ (envelope-from ) for ; Fri, 24 Feb 2023 14:22:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6A16HAy6+GPz5gAAauVa8A (envelope-from ) for ; Fri, 24 Feb 2023 14:22:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DE23FAD4 for ; Fri, 24 Feb 2023 14:22:20 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JMXd7600; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677244940; a=rsa-sha256; cv=none; b=VXWxY9wTXP0AnqZxDA8cFpUf3I+MNuaLcBQHFX7LjdWgLnZS8/CdIegtoiIn+qxXsXRijq 4bwD5hpQRGTnkWO5U2N38n5vEs+EHt88Y85pzL94MDrDWFMC1+6ofxoURdnyORILHSkGpF nL+bstQTltlgPSJwyiA1jNqXj9y+vTRcPhvjGSv9ZWBksrN2DS/LnCkQqy+1B57mI+3cnn BQYNYkHioEBTX096qMr7u8WSe6H3hAf1OUB1xmHjprsK8aXvrpjIsn+z92F37W7F8ZZvtD CfTC6n6FXCrbnH68DWn/XuZpx+qKVVg8iwBYXjmvI3HKQwtIdeXd4QPfg1V8Vg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=JMXd7600; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677244940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ACacFfWOv8dfQsCc7GpzAhHEx5VFP51GZBsRAtBKTuI=; b=FUbINRHaXihtUc0L3vL9WxZBRV9jvIXDfEwSOMlcOEybW79jV6TwZMB/39Hor4hZ18J5Km BdoVnJeu87VmlzDdPB/bYI9Dd57jZ6p0PK8XtRHHOJzOfmZrxMgiUqFxHWiK2UqRgCzR6Q +D68xRhEPKuN1YcFidQR7/uVybmubCh6+3d5k9gALMxF1CyhVA4GwTj7sJRDamVNMK7hF3 AV765+a8Aue/zx8a7cZog2rGXOJpKQ09qOkD19M9RMftj43iiqsLOm4E4rwqJKcKzVVFkq sKyMdRN4QVP1cjI/78lwpsREDD9/nKNMLbSoC+U7CT+qRjc7R+mgam9VVav1Kw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVY1Y-0002bU-Ch; Fri, 24 Feb 2023 08:22:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVY1S-0002bB-AQ for bug-guix@gnu.org; Fri, 24 Feb 2023 08:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVY1S-0003Xh-1p for bug-guix@gnu.org; Fri, 24 Feb 2023 08:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVY1R-0005ih-R3 for bug-guix@gnu.org; Fri, 24 Feb 2023 08:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61684: can't compose 'with-patch' with 'with-source' Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 24 Feb 2023 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61684 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon Tournier Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 61684@debbugs.gnu.org Received: via spool by 61684-submit@debbugs.gnu.org id=B61684.167724487021922 (code B ref 61684); Fri, 24 Feb 2023 13:22:01 +0000 Received: (at 61684) by debbugs.gnu.org; 24 Feb 2023 13:21:10 +0000 Received: from localhost ([127.0.0.1]:36289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVY0c-0005hU-0B for submit@debbugs.gnu.org; Fri, 24 Feb 2023 08:21:10 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:43563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVY0a-0005hI-3z for 61684@debbugs.gnu.org; Fri, 24 Feb 2023 08:21:08 -0500 Received: by mail-qt1-f176.google.com with SMTP id cf14so4186290qtb.10 for <61684@debbugs.gnu.org>; Fri, 24 Feb 2023 05:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ACacFfWOv8dfQsCc7GpzAhHEx5VFP51GZBsRAtBKTuI=; b=JMXd7600ZDhNCnRqc4IjLnC8fLdYpO9Wb+d6LLbCWwT6X3N++rHFk0QKQKkOQvCr7q oQXSTy2lSTXfopDCFLw7JaxAM6yCVnrxdFVy2IoaGY+eb4Z5KpJHYJ8m9S/4zzzpg6B8 TSaeiQAE9VWODMBrNX90VAg/e6on2rECGwZKvTCLa/vWxegpptKpZBVlH+rjQhI2/5/j 1mr6WvEtGojz7hw55IkRgKHXnPxL9EjxbD5asBEX6TO6nFTNii3lNLtxYITKmWLukaxx SMymj6C9tw/OlHIZAnOirLmlp9W3rxiZjHYorqOQRPdEUDQsIfrOSTBsULvu15KD+HBF Arkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ACacFfWOv8dfQsCc7GpzAhHEx5VFP51GZBsRAtBKTuI=; b=vV5oihR1R1zczvXU7X0uxpjQRK4b2L7I/x0a9iG7IghNO18cAYkmtefDfF3nJFSiHT 2tRswduGknr8q6iUxUR/aleOg/Onxg/rbVAtFWT/wOYyWDh7S8CzJAQi9U2pNAQkAcrZ rDRacnTwzT+Bkg7MrPq5A1ZPdbwv6248l3PwDv4AzlbWMf6+NwIL+ojXDidMmvjqUDfw ByoZOCixJ/f2bWChGpwYOGFnV09GlEHIVLMa4AiIspDTSIK+xS/NuHfris9rd6F2Vk+y r51I0GuanJl/JrJA4k6H5Bg7mHxd9apPr3Z0d4zSVIsiMkASYuvjfum9lWGNAgqEsCRR DZQQ== X-Gm-Message-State: AO0yUKWfzh1mPDCS3x7D50XZljhxTzGo4eh61wPj8Zz2ihCHmU1iNmqb 78kpay3p44wWOK2SRFh2BZxNJ61YlxX3iA== X-Google-Smtp-Source: AK7set+/U8/lxgvGds1G2ecwrP7ASMYeNpW7n/nCsgDNJjf/v1lvO3+QXnruaLb7uL490OG7jjaiTQ== X-Received: by 2002:a05:622a:138d:b0:3b6:3ad0:5470 with SMTP id o13-20020a05622a138d00b003b63ad05470mr26578540qtk.31.1677244862332; Fri, 24 Feb 2023 05:21:02 -0800 (PST) Received: from hurd (dsl-141-27.b2b2c.ca. [66.158.141.27]) by smtp.gmail.com with ESMTPSA id 138-20020a370890000000b00741e27ecb37sm6754830qki.74.2023.02.24.05.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 05:21:01 -0800 (PST) From: Maxim Cournoyer References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> Date: Fri, 24 Feb 2023 08:21:00 -0500 In-Reply-To: <875ybrmfuv.fsf@gmail.com> (Simon Tournier's message of "Fri, 24 Feb 2023 13:02:00 +0100") Message-ID: <87h6vbgpxf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 1DE23FAD4 X-Spam-Score: -2.58 X-Migadu-Spam-Score: -2.58 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: ARtqtieO7ohu Hello, Simon Tournier writes: > Hi, > > On jeu., 23 f=C3=A9vr. 2023 at 17:27, Maxim Cournoyer wrote: > >> Hm. That seems sub-optimal; it seems to me that ideally, the >> transformations would be additive, so that users would not need to care >> about the ordering. Or perhaps, alternatively, we could enforce such >> ordering at the implementation level (sorting the transformations in the >> order that is required). > > From my point of view (and what I tried stopping in the middle :-)) is > to report if the transformation makes sense or not. For instance, > > with-patch > with-source > > makes sense contrary to > > with-source > with-patch > > and it would already be an improvement to report that the latter > transformation does not make sense instead of silently does nothing or > raises some weird errors. > > Well, I am not convinced that enforce the ordering is a good thing > because as Ludo said, some HPC user exploits this control of ordering to > generate complex transformations. Could we gather more information about that use case? It needs to be clear if we are to constrain the design (solution) by it. > To me, the fix is: > > 1. document the ordering bits > 2. check if the ordering =E2=80=9Cmakes sense=E2=80=9C and raises if not. If the use case above (the one where transformation order matters and are useful) is expounded and appears reasonable, then yes, that seems like a good solution. Such a use case could appear in a complex example next to the documentation that explains the ordering "rules". --=20 Thanks, Maxim