From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: raingloom <raingloom@riseup.net>
Cc: 52654@debbugs.gnu.org
Subject: bug#52654: shepherd lacks error reporting
Date: Sat, 29 Apr 2023 11:22:27 -0400 [thread overview]
Message-ID: <87h6syaf2k.fsf@gmail.com> (raw)
In-Reply-To: <20211219070207.1195510c@riseup.net> (raingloom@riseup.net's message of "Sun, 19 Dec 2021 07:02:07 +0100")
Hi,
I also encountered that issue, it's really puzzling.
Here's the problematic start slot that got my mpd test to hang the boot,
with the last message being "Please wait while gathering entropy to
generate the key pair;":
--8<---------------cut here---------------start------------->8---
(start
(with-imported-modules (source-module-closure
'((gnu build activation)))
#~(begin
(use-modules (gnu build activation))
(let ((user (getpw #$username)))
(define (init-directory directory)
(unless (file-exists? directory)
(mkdir-p/perms directory user #o755)))
(for-each
init-directory
(cons '#$(map dirname
;; XXX: Delete the potential "syslog"
;; log-file value, which is not a directory.
(delete "syslog"
(filter-map maybe-value
(list db-file
log-file
state-file
sticker-file)))))))
(make-forkexec-constructor
(list #$(file-append package "/bin/mpd") "--no-daemon"
#$config-file)
#:environment-variables '#$environment-variables))))
--8<---------------cut here---------------end--------------->8---
The error was the lonely cons. Taking it out, the test then passed:
--8<---------------cut here---------------start------------->8---
(start
(with-imported-modules (source-module-closure
'((gnu build activation)))
#~(begin
(use-modules (gnu build activation))
(let ((user (getpw #$username)))
(define (init-directory directory)
(unless (file-exists? directory)
(mkdir-p/perms directory user #o755)))
(for-each
init-directory
'#$(map dirname
;; XXX: Delete the potential "syslog"
;; log-file value, which is not a directory.
(delete "syslog"
(filter-map maybe-value
(list db-file
log-file
state-file
sticker-file))))))
(make-forkexec-constructor
(list #$(file-append package "/bin/mpd") "--no-daemon"
#$config-file)
#:environment-variables '#$environment-variables))))
--8<---------------cut here---------------end--------------->8---
Shepherd should report the error, fail that one service and attempt to
keep booting (if the service is not required by other critical ones).
--
Thanks,
Maxim
prev parent reply other threads:[~2023-04-29 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-19 5:13 bug#52654: shepherd lacks error reporting raingloom
2021-12-19 6:02 ` raingloom
2023-04-29 15:22 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6syaf2k.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=52654@debbugs.gnu.org \
--cc=raingloom@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).