unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Janneke Nieuwenhuizen <janneke@gnu.org>
Cc: othacehe@gnu.org, ludo@gnu.org, me@tobias.gr,
	efraim@flashner.co.il, rekado@elephly.net, 66097@debbugs.gnu.org
Subject: bug#66097: New test "rewrite-url, without to-version" needs network
Date: Wed, 20 Sep 2023 14:05:44 -0400	[thread overview]
Message-ID: <87h6no4t53.fsf@gmail.com> (raw)
In-Reply-To: <87y1h2kb2i.fsf@gnu.org> (Janneke Nieuwenhuizen's message of "Tue, 19 Sep 2023 07:04:53 +0200")

Hi Janneke!

Janneke Nieuwenhuizen <janneke@gnu.org> writes:

> Hi Maxim,
>
> As mentioned on IRC, the recently-added "rewrite-url, without
> to-version" test needs not only nss-certs installed, as I found when
> building it for the Hurd.  New we also found it to fail in a container
> without network access.  That means a guix package build (in a
> container) now fails.

Ouch!  That's clearly not intended.

> After I updated the guix version to 1.4.0-11.658de25e99 yesterday
> morning to (finally) get `guix pull' to work on the Hurd, several people
> reported failure to reconfigure on IRC.
>
> This
>
>     guix shell -CD guix
>     export SCM_LOG_DRIVER_FLAGS="--select=^rewrite-url, without to-version"
>     make check TESTS=tests/gnu-maintenance.scm
>
> gives
>
> test-name: rewrite-url, without to-version
> [..]
> expected-value: "https://dist.libuv.org/dist/v1.46.0/libuv-v1.46.0.tar.gz"
> actual-value: #f
> actual-error:
> + (getaddrinfo-error -8)
> result: FAIL
>
>
> When changing the code like this
>
> -(test-equal "rewrite-url, without to-version"
> +(pk "rewrite-url, without to-version"
>    "https://dist.libuv.org/dist/v1.46.0/libuv-v1.46.0.tar.gz"
> -  (with-http-server
> +  "=>"(with-http-server

Thanks for the reproducer.  I'll look into fixing the problem.  I
believe it's a matter of adding more mocked server replies.  I must have
miscounted how many were needed.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-09-20 18:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  5:04 bug#66097: New test "rewrite-url, without to-version" needs network Janneke Nieuwenhuizen
2023-09-20 18:05 ` Maxim Cournoyer [this message]
2023-09-27 22:09   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6no4t53.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66097@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=janneke@gnu.org \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).