unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: control@debbugs.gnu.org, Tobias Geerinckx-Rice <me@tobias.gr>,
	"Perry, Daniel J" <dperry45@gatech.edu>,
	66358@debbugs.gnu.org
Subject: bug#66358: Some options are really subcommands + ignore arguments
Date: Tue, 24 Oct 2023 10:48:18 -0400	[thread overview]
Message-ID: <87h6mg3wlp.fsf_-_@gmail.com> (raw)
In-Reply-To: <86pm1kd9kd.fsf@gmail.com> (Simon Tournier's message of "Thu, 12 Oct 2023 01:27:14 +0200")

Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi,
>
> On Mon, 09 Oct 2023 at 14:25, Tobias Geerinckx-Rice via Bug reports
> for GNU Guix <bug-guix@gnu.org> wrote:
>
>> I think it would be less surprising if these ‘single, mutually exclusive 
>> actions’ should always be (sub)subcommands, e.g., ‘guix archive import’, 
>> ‘guix archive authorize’, …
>
> I am proposing to error for ambiguous cases as,
>
>     $ ./pre-inst-env guix archive --import --authorize hello < /tmp/hello.nar
>     guix archive: error: ambiguous options: "authorize" with "import"
>
> See attached patch.  WDYT?
>
> Please note that it errors when at least 2 options are ambiguous.  So if
> there is 3, you get the “two first ones“.

It seems a reasonable improvement to me, but I think *all* the
incompatible errors should be accumulated and printed in one go.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-10-24 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05  3:35 bug#66358: Can't import package using archive command Perry, Daniel J
2023-10-09 12:25 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2023-10-11 23:27   ` Simon Tournier
2023-10-24 14:48     ` Maxim Cournoyer [this message]
2023-10-24 16:39       ` bug#66358: Some options are really subcommands + ignore arguments Simon Tournier
2023-10-09 12:32 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2023-10-09 16:52 ` bug#66358: Now what about firmware? Perry, Daniel J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6mg3wlp.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66358@debbugs.gnu.org \
    --cc=control@debbugs.gnu.org \
    --cc=dperry45@gatech.edu \
    --cc=me@tobias.gr \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).