* bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.
[not found] ` <0d5eafab955b7a9c3d2f2163fe3f3aa35a45e62d.1721407706.git.liliana.prikler@gmail.com>
@ 2024-07-20 14:31 ` Suhail Singh
2024-07-20 15:02 ` Liliana Marie Prikler
0 siblings, 1 reply; 7+ messages in thread
From: Suhail Singh @ 2024-07-20 14:31 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: cox.katherine.e+guix, 72045, Suhail Singh, andrew
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> + ;; Run `make check-system TESTS=emacs-native-comp' to ensure that grafts
> + ;; can meaningfully be applied.
Either this isn't the correct invocation or I am doing something wrong.
Running that command in guix checkout seems to run many tests (possibly
all of them?). After applying this patch I get the following test suite
summary:
#+begin_quote
...
============================================================================
Testsuite summary for GNU Guix 1.4.0-23.843b85c
============================================================================
# TOTAL: 2451
# PASS: 2341
# SKIP: 86
# XFAIL: 2
# FAIL: 22
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to bug-guix@gnu.org
============================================================================
...
#+end_quote
--
Suhail
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.
2024-07-20 14:31 ` bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft Suhail Singh
@ 2024-07-20 15:02 ` Liliana Marie Prikler
2024-07-20 15:25 ` Suhail Singh
0 siblings, 1 reply; 7+ messages in thread
From: Liliana Marie Prikler @ 2024-07-20 15:02 UTC (permalink / raw)
To: Suhail Singh; +Cc: cox.katherine.e+guix, 72045, andrew
Am Samstag, dem 20.07.2024 um 10:31 -0400 schrieb Suhail Singh:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > + ;; Run `make check-system TESTS=emacs-native-comp' to ensure
> > that grafts
> > + ;; can meaningfully be applied.
>
> Either this isn't the correct invocation or I am doing something
> wrong. Running that command in guix checkout seems to run many tests
> (possibly all of them?). After applying this patch I get the
> following test suite summary:
>
> #+begin_quote
> ...
>
> =====================================================================
> Testsuite summary for GNU Guix 1.4.0-23.843b85c
> =====================================================================
> # TOTAL: 2451
> # PASS: 2341
> # SKIP: 86
> # XFAIL: 2
> # FAIL: 22
> # XPASS: 0
> # ERROR: 0
>
> =====================================================================
> See ./test-suite.log
> Please report to bug-guix@gnu.org
> =====================================================================
> ...
> #+end_quote
Well, I get
#+begin_quote
Selected 1 system tests...
/gnu/store/rszxrbzryn0cwmdq5mppr7yqqgij4gzd-emacs-native-comp-
compatible
#+end_quote
That's quite strange.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.
2024-07-20 15:02 ` Liliana Marie Prikler
@ 2024-07-20 15:25 ` Suhail Singh
2024-07-20 15:42 ` Liliana Marie Prikler
0 siblings, 1 reply; 7+ messages in thread
From: Suhail Singh @ 2024-07-20 15:25 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: cox.katherine.e+guix, 72045, Suhail Singh, andrew
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Selected 1 system tests...
I get this line as well early on. However, after that lots more things
happen.
Could you please confirm the guix checkout commit you're applying your
patch on?
--
Suhail
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.
2024-07-20 15:25 ` Suhail Singh
@ 2024-07-20 15:42 ` Liliana Marie Prikler
2024-07-20 16:34 ` Suhail Singh
0 siblings, 1 reply; 7+ messages in thread
From: Liliana Marie Prikler @ 2024-07-20 15:42 UTC (permalink / raw)
To: Suhail Singh; +Cc: cox.katherine.e+guix, 72045, andrew
Am Samstag, dem 20.07.2024 um 11:25 -0400 schrieb Suhail Singh:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > Selected 1 system tests...
>
> I get this line as well early on. However, after that lots more
> things happen.
>
> Could you please confirm the guix checkout commit you're applying
> your patch on?
Commit 9724e61cda80e4c59a2eb419a453887ecc551b9a, plus some very
unrelated stuff I have lying locally on master. Particularly, commits
to sign off.
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.
2024-07-20 15:42 ` Liliana Marie Prikler
@ 2024-07-20 16:34 ` Suhail Singh
2024-07-20 16:47 ` Suhail Singh
2024-07-21 10:05 ` Liliana Marie Prikler
0 siblings, 2 replies; 7+ messages in thread
From: Suhail Singh @ 2024-07-20 16:34 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: cox.katherine.e+guix, 72045, Suhail Singh, andrew
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Commit 9724e61cda80e4c59a2eb419a453887ecc551b9a
Okay, I can confirm that it's working when applied on that commit.
I am not sure whether the issue I was observing on
24163eea584663568b68e19f364256fc7396b61f were due to incorrect
configuration on my part or something else (jury is out on that one).
However, for the purposes of #72045 I believe v3 looks good.
--
Suhail
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.
2024-07-20 16:34 ` Suhail Singh
@ 2024-07-20 16:47 ` Suhail Singh
2024-07-21 10:05 ` Liliana Marie Prikler
1 sibling, 0 replies; 7+ messages in thread
From: Suhail Singh @ 2024-07-20 16:47 UTC (permalink / raw)
To: Suhail Singh; +Cc: cox.katherine.e+guix, 72045, Liliana Marie Prikler, andrew
Suhail Singh <suhailsingh247@gmail.com> writes:
> I am not sure whether the issue I was observing on
> 24163eea584663568b68e19f364256fc7396b61f
Ah. I was simply unlucky. The failing tests were related to the build
of guile 3.0.10. This commit has since been reverted in master.
Apologies for the noise.
--
Suhail
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.
2024-07-20 16:34 ` Suhail Singh
2024-07-20 16:47 ` Suhail Singh
@ 2024-07-21 10:05 ` Liliana Marie Prikler
1 sibling, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2024-07-21 10:05 UTC (permalink / raw)
To: Suhail Singh; +Cc: cox.katherine.e+guix, 72045-done, andrew
Am Samstag, dem 20.07.2024 um 12:34 -0400 schrieb Suhail Singh:
> However, for the purposes of #72045 I believe v3 looks good.
For the purposes of #72045, I'm marking it as done.
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-21 10:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5a6cca57339644f65185e61cc25ecc4f17371432.1721407706.git.liliana.prikler@gmail.com>
[not found] ` <0d5eafab955b7a9c3d2f2163fe3f3aa35a45e62d.1721407706.git.liliana.prikler@gmail.com>
2024-07-20 14:31 ` bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft Suhail Singh
2024-07-20 15:02 ` Liliana Marie Prikler
2024-07-20 15:25 ` Suhail Singh
2024-07-20 15:42 ` Liliana Marie Prikler
2024-07-20 16:34 ` Suhail Singh
2024-07-20 16:47 ` Suhail Singh
2024-07-21 10:05 ` Liliana Marie Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).