bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

[Suhail Singh]

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> +    ;; Run `make check-system TESTS=emacs-native-comp' to ensure that grafts
> +    ;; can meaningfully be applied.

Either this isn't the correct invocation or I am doing something wrong.
Running that command in guix checkout seems to run many tests (possibly
all of them?).  After applying this patch I get the following test suite
summary:

#+begin_quote
  ...
  ============================================================================
  Testsuite summary for GNU Guix 1.4.0-23.843b85c
  ============================================================================
  # TOTAL: 2451
  # PASS:  2341
  # SKIP:  86
  # XFAIL: 2
  # FAIL:  22
  # XPASS: 0
  # ERROR: 0
  ============================================================================
  See ./test-suite.log
  Please report to bug-guix@gnu.org
  ============================================================================
  ...
#+end_quote

-- 
Suhail

bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

[Liliana Marie Prikler]

Am Samstag, dem 20.07.2024 um 10:31 -0400 schrieb Suhail Singh:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > +    ;; Run `make check-system TESTS=emacs-native-comp' to ensure
> > that grafts
> > +    ;; can meaningfully be applied.
> 
> Either this isn't the correct invocation or I am doing something
> wrong.  Running that command in guix checkout seems to run many tests
> (possibly all of them?).  After applying this patch I get the
> following test suite summary:
> 
> #+begin_quote
>   ...
>  
> =====================================================================
>   Testsuite summary for GNU Guix 1.4.0-23.843b85c
> =====================================================================
>   # TOTAL: 2451
>   # PASS:  2341
>   # SKIP:  86
>   # XFAIL: 2
>   # FAIL:  22
>   # XPASS: 0
>   # ERROR: 0
>  
> =====================================================================
>   See ./test-suite.log
>   Please report to bug-guix@gnu.org
> =====================================================================
>   ...
> #+end_quote
Well, I get

#+begin_quote
Selected 1 system tests...
/gnu/store/rszxrbzryn0cwmdq5mppr7yqqgij4gzd-emacs-native-comp-
compatible
#+end_quote

That's quite strange.

bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

[Suhail Singh]

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Selected 1 system tests...

I get this line as well early on.  However, after that lots more things
happen.

Could you please confirm the guix checkout commit you're applying your
patch on?

-- 
Suhail

bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

[Liliana Marie Prikler]

Am Samstag, dem 20.07.2024 um 11:25 -0400 schrieb Suhail Singh:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > Selected 1 system tests...
> 
> I get this line as well early on.  However, after that lots more
> things happen.

> 
> Could you please confirm the guix checkout commit you're applying
> your patch on?
Commit 9724e61cda80e4c59a2eb419a453887ecc551b9a, plus some very
unrelated stuff I have lying locally on master.  Particularly, commits
to sign off.

Cheers

bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

[Suhail Singh]

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Commit 9724e61cda80e4c59a2eb419a453887ecc551b9a

Okay, I can confirm that it's working when applied on that commit.

I am not sure whether the issue I was observing on
24163eea584663568b68e19f364256fc7396b61f were due to incorrect
configuration on my part or something else (jury is out on that one).
However, for the purposes of #72045 I believe v3 looks good.

-- 
Suhail

bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

[Suhail Singh]

Suhail Singh <suhailsingh247@gmail.com> writes:

> I am not sure whether the issue I was observing on
> 24163eea584663568b68e19f364256fc7396b61f

Ah.  I was simply unlucky.  The failing tests were related to the build
of guile 3.0.10.  This commit has since been reverted in master.
Apologies for the noise.

-- 
Suhail

bug#72045: [PATCH v3 2/2] gnu: emacs-minimal: Ungraft.

[Liliana Marie Prikler]

Am Samstag, dem 20.07.2024 um 12:34 -0400 schrieb Suhail Singh:
> However, for the purposes of #72045 I believe v3 looks good.
For the purposes of #72045, I'm marking it as done.

Cheers