Re: List of abbreviations for licenses

[ludo@gnu.org (Ludovic Courtès)]

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> From eb8229c7834dd1d249e8f5adc8382d00b289aa00 Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <nikita@karetnikov.org>
> Date: Thu, 6 Dec 2012 22:39:57 +0000
> Subject: [PATCH] Add (guix licenses).
>
> * guix/licenses.scm: New file.
> * Makefile.am (MODULES): Add it.

Thanks, looks good to me.

> +(define-module (guix licenses)
> +  #:use-module (srfi srfi-9)
> +  #:export (asl2.0)
> +  #:export (boost1.0)
> +  #:export (bsd-2 bsd-3 bsd-4)
> +  #:export (cddl1.0)
> +  #:export (cpl1.0)
> +  #:export (epl1.0)
> +  #:export (gpl2 gpl2+ gpl3 gpl3+)
> +  #:export (ijg)
> +  #:export (ibmpl1.0)
> +  #:export (lgpl2.1 lgpl2.1+ lgpl3 lgpl3+)
> +  #:export (mpl2.0)
> +  #:export (openssl)
> +  #:export (public-domain)
> +  #:export (x11)
> +  #:export (zlib))

Can you make this a single #:export?

Also, make sure to export ‘license?’ and ‘license-name’.

Could you add a small “Commentary:” block at the beginning, and a “ends
here” lines at the end?  See, for instance, guix/download.scm for an
example.

This allows for on-line documentation:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (module-commentary '(guix download))
$4 = "\n Produce fixed-output derivations with data fetched over HTTP or FTP.\n\n"
--8<---------------cut here---------------end--------------->8---

(Likewise with C-d RET in Geiser.)

Thanks!

Ludo’.