[PATCH] distro: Add Kmod.

[PATCH] distro: Add Kmod.

[Nikita Karetnikov]

[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]

Hi,

Can we fix the following? Should we report it instead?

TESTSUITE: ERR: sizes do not match /tmp/nix-build-p7bkz7iscax3f0998gss17sfm83k9v7q-kmod-12.drv-0/kmod-12/testsuite/rootfs/test-depmod/modules-order-compressed/lib/modules/3.5.4-1-ARCH/correct-modules.alias /tmp/nix-build-p7bkz7iscax3f0998gss17sfm83k9v7q-kmod-12.drv-0/kmod-12/testsuite/rootfs/test-depmod/modules-order-compressed/lib/modules/3.5.4-1-ARCH/modules.alias
TESTSUITE: ERR: FAILED: exit ok but outputs do not match: depmod_modules_order_for_compressed
FAIL: testsuite/test-depmod
==============================================
2 of 10 tests failed
Please report to linux-modules@vger.kernel.org
==============================================

Can I push it without tests?

Nikita

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-distro-Add-Kmod.patch --]
[-- Type: text/x-diff, Size: 1980 bytes --]

From 6635ce4de63f74c142ae8bb20cd398fa55c950f8 Mon Sep 17 00:00:00 2001
From: Nikita Karetnikov <nikita@karetnikov.org>
Date: Wed, 19 Dec 2012 02:06:27 +0000
Subject: [PATCH] distro: Add Kmod.

* distro/packages/linux.scm (kmod): New variable.
---
 distro/packages/linux.scm |   31 ++++++++++++++++++++++++++++++-
 1 files changed, 30 insertions(+), 1 deletions(-)

diff --git a/distro/packages/linux.scm b/distro/packages/linux.scm
index 07be3ac..3431e56 100644
--- a/distro/packages/linux.scm
+++ b/distro/packages/linux.scm
@@ -193,4 +193,33 @@ providing the system administrator with some help in common tasks.")
      "Tools for working with USB devices, such as lsusb")
     (description
      "Tools for working with USB devices, such as lsusb.")
-    (license gpl2+)))
\ No newline at end of file
+    (license gpl2+)))
+
+(define-public kmod
+  (package
+    (name "kmod")
+    (version "12")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://kernel.org/linux/utils/kernel/kmod/kmod-"
+                          version ".tar.xz"))
+      (sha256
+       (base32
+        "0bzrifz0qr5kd5c7wszx36hxzm8cihcbs1l59qidks51qpc9s666"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--disable-manpages") ; XXX: requires xsltproc
+       #:tests? #f))                             ; testsuite/test-depmod fails
+    (inputs `(("pkg-config" ,pkg-config)
+              ("xz" ,guix:xz)
+              ("zlib" ,guix:zlib)))
+    (home-page
+     "https://www.kernel.org/pub/linux/utils/kernel/kmod/")
+    (synopsis
+     "Kmod, a set of tools for managing modules of the Linux kernel")
+    (description
+     "Kmod is a set of tools to handle common tasks with modules of the
+Linux kernel (e.g., insert, remove, list, check properties, resolve
+dependencies and aliases).")
+    (license '(gpl2+ lgpl2.1+))))
\ No newline at end of file
-- 
1.7.5.4


[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] distro: Add Kmod.

[Ludovic Courtès]

Hi,

Nikita Karetnikov <nikita@karetnikov.org> skribis:

> Can we fix the following? Should we report it instead?
>
> TESTSUITE: ERR: sizes do not match /tmp/nix-build-p7bkz7iscax3f0998gss17sfm83k9v7q-kmod-12.drv-0/kmod-12/testsuite/rootfs/test-depmod/modules-order-compressed/lib/modules/3.5.4-1-ARCH/correct-modules.alias /tmp/nix-build-p7bkz7iscax3f0998gss17sfm83k9v7q-kmod-12.drv-0/kmod-12/testsuite/rootfs/test-depmod/modules-order-compressed/lib/modules/3.5.4-1-ARCH/modules.alias
> TESTSUITE: ERR: FAILED: exit ok but outputs do not match: depmod_modules_order_for_compressed
> FAIL: testsuite/test-depmod
> ==============================================
> 2 of 10 tests failed
> Please report to linux-modules@vger.kernel.org
> ==============================================

Can you look at the detailed build logs?

Often, when tests fail to build in our chroot, that’s because:

  • they refer to absolute file names (/usr/bin/modprobe,
    /lib/modules/xxx, etc.)

  • they have scripts with shebangs pointing to a file missing in the
    chroot (#!/usr/bin/env, #!/bin/bash, etc.)

  • they attempt to do name lookups, which fails because the chroot
    lacks /etc/resolv.conf, /etc/services, etc.

If that is the case, a phase must be inserted before the ‘check’ phase
to adjust the faulty files.

HTH,
Ludo’.

Re: [PATCH] distro: Add Kmod.

[Nikita Karetnikov]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

>>> Can you look at the detailed build logs?

>> 'config.log' contains several errors. For instance:
>>
>> conftest.c:11:28: fatal error: ac_nonexistent.h: No such file or directory
>> compilation terminated.
>>
>> Is it important?

> That’s expected: configure tests for the presence of certain features,
> and some are missing, etc.

>> This (from 'test-depmod.c') looks suspicious:
>>
>> #define MODULES_ORDER_LIB_MODULES MODULES_ORDER_ROOTFS "/lib/modules/" MODULES_ORDER_UNAME
>>
>> (I don't know C.)
>>
>> Also, 'test-testsuite.c' contains the following:
>>
>> fp = fopen("/lib/modules/a", "r");
>>
>> fd = open("/lib/modules/a", O_RDONLY);

> Yeah, this will never work for us, because there’s no /lib.
>
> I support we’d rather ignore tests for now, with a comment explaining
> that this is kernel-dependent, and that we’ll revisit the issue when we
> have a bootable distro.

OK.

> Why do you need this, BTW?  It’ll be essentially unusable at this stage
> because of the above.

'udev-182' depends on 'kmod'. 

'guix-import' doesn't list 'kmod' in 'inputs' for 'udev-173'. I can try
to package it instead of 'udev-182'. It might also solve the error which
is described in the "How to adjust PKG_CONFIG_PATH?" thread.

Nikita


[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] distro: Add Kmod.

[Nikita Karetnikov]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

> 'guix-import' doesn't list 'kmod' in 'inputs' for 'udev-173'. I can try
> to package it instead of 'udev-182'. It might also solve the error which
> is described in the "How to adjust PKG_CONFIG_PATH?" thread.

Hmm, the only mirror that hosts 'udev-173' is this one. [1] The
package is signed, but the key was revoked.

That's why I decided to install 'udev-174' from the official
repository. Unfortunately, it failed with a similar error:

configure: error: Package requirements (glib-2.0 >= 2.22.0 gobject-2.0 >= 2.22.0) were not met:

No package 'glib-2.0' found
No package 'gobject-2.0' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Nikita

[1] http://kernel.osuosl.org/pub/linux/utils/kernel/hotplug/


[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] distro: Add Kmod.

[Ludovic Courtès]

Hi!

Nikita Karetnikov <nikita@karetnikov.org> skribis:

> That's why I decided to install 'udev-174' from the official
> repository. Unfortunately, it failed with a similar error:
>
> configure: error: Package requirements (glib-2.0 >= 2.22.0 gobject-2.0 >= 2.22.0) were not met:

Yeah, we don’t have GLib and co. packaged, right?  Two solutions: either
you package them, or you check whether udev’s configure has a
--without-glib (or similar) option to start with.

Thanks,
Ludo’.