unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 25414@debbugs.gnu.org
Subject: bug#25414: gdk-pixbuf@2.34.0 does not build deterministically
Date: Thu, 12 Jan 2017 14:14:59 +0100	[thread overview]
Message-ID: <87fuko5sj0.fsf@gnu.org> (raw)
In-Reply-To: <20170111231332.4812530e@scratchpost.org> (Danny Milosavljevic's message of "Wed, 11 Jan 2017 23:13:32 +0100")

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

>> Sounds like the right approach, would you like to test it?  :-)
>
> In principle yes,

I mean, can you apply the patch and build it with:

  guix build gdk-pixbuf --rounds=2 -K

?

> but even without the patch I get (using current master):
>
> $ ./pre-inst-env  guix challenge gdk-pixbuf --substitute-urls="https://mirror.hydra.gnu.org https://bayfront.guixsd.org"

[...]

>  575: 2 [map #<procedure 74335a0 at guix/scripts/challenge.scm:125:46 (t-1367901)> ...]
> In guix/scripts/substitute.scm:
>  687: 1 [lookup-narinfos "\"https://mirror.hydra.gnu.org" #]
>  659: 0 [fetch-narinfos "\"https://mirror.hydra.gnu.org" #]
>
> guix/scripts/substitute.scm:659:16: In procedure fetch-narinfos:
> guix/scripts/substitute.scm:659:16: In procedure struct_vtable: Wrong type argument in position 1 (expecting struct): #f

Hmm hmm!  Is it reproducible (it works for me)?  If so, could you try to
see where the problem comes from by adding ‘pk’ calls like this:

--8<---------------cut here---------------start------------->8---
diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
index 524b019a3..26ed81318 100755
--- a/guix/scripts/substitute.scm
+++ b/guix/scripts/substitute.scm
@@ -657,10 +657,10 @@ if file doesn't exist, and the narinfo otherwise."
 
   (let-values (((cache-info port)
                 (download-cache-info url)))
-    (and cache-info
+    (and (pk 'cache-info cache-info)
          (if (string=? (cache-info-store-directory cache-info)
                        (%store-prefix))
-             (do-fetch (string->uri url) port)    ;reuse PORT
+             (do-fetch (pk 'uri (string->uri url)) port)  ;reuse PORT
              (begin
                (warning (_ "'~a' uses different store '~a'; ignoring it~%")
                         url (cache-info-store-directory cache-info))
--8<---------------cut here---------------end--------------->8---

Thanks,
Ludo’.

  reply	other threads:[~2017-01-12 13:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 23:06 bug#25414: gdk-pixbuf@2.34.0 does not build deterministically Ludovic Courtès
2017-01-10 23:33 ` Danny Milosavljevic
2017-01-11 21:16   ` Ludovic Courtès
2017-01-11 22:13     ` Danny Milosavljevic
2017-01-12 13:14       ` Ludovic Courtès [this message]
2017-01-14  9:21         ` Danny Milosavljevic
2017-01-15  1:22           ` bug#25414: [PATCH] gnu: gdk-pixbuf: Make it reproducible Danny Milosavljevic
     [not found]           ` <20170115012207.2604-1-dannym@scratchpost.org>
2017-01-16 13:44             ` Ludovic Courtès
     [not found]             ` <874m0zyva3.fsf@gnu.org>
2017-01-16 15:48               ` Danny Milosavljevic
2017-06-05  4:53 ` Danny Milosavljevic
2017-06-05 20:43   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuko5sj0.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=25414@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).