From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#29537: Core updates broken Date: Sun, 03 Dec 2017 19:43:08 +0100 Message-ID: <87fu8rzm83.fsf@fastmail.com> References: <87vahnzyq9.fsf@fastmail.com> <87bmjf4r0k.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLZFG-000423-UV for bug-guix@gnu.org; Sun, 03 Dec 2017 13:44:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLZFC-00011M-1Q for bug-guix@gnu.org; Sun, 03 Dec 2017 13:44:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:35063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLZFB-00011E-SQ for bug-guix@gnu.org; Sun, 03 Dec 2017 13:44:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLZFB-0005Iz-IN for bug-guix@gnu.org; Sun, 03 Dec 2017 13:44:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87bmjf4r0k.fsf@elephly.net> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ricardo Wurmus Cc: 29537@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Marius Bakke writes: > >> G=C3=A1bor Boskovits writes: >> >>> It seems, that we have a breakage in current core-updates. m4, gettext,= and >>> at least a few other packages fail to build. >> >> Hello! >> >> The problem is that the glibc version string is used a couple of places >> to determine where locales are found. >> >> The attached patch fixes it, though I'm not sure if it's the best >> approach. Thoughts? > > Thank you. > > I find it a little ugly to replace the exact version string with only > the major+minor version substring. Why can=E2=80=99t we use the full ver= sion > string? I think it's because "glibc-versioned-locpath.patch" uses the libc VERSION constant. Perhaps we could substitute glibcs "version.h", but that might break other things. Or introduce a different variable, say GUIX_GLIBC_VERSION, and use that. WDYT? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlokRbwACgkQoqBt8qM6 VPoZDgf9Gy0CFqJIr8JOyARuhJrKXGVRSjYRCiOzcQzh5+FQe1L1Wz1TLY2shwUJ Co0EcwrppY0PbdngZYSjLsanmtOy/K67LlwPL/PAQ7xiL2urF1QCmqSlRBkBVCNP HqviNkUAKuKwAi6E658dLAVTDH4+SonnmYLA/nY3qH4ILEYHieZPRUXozJkvbt2S Mpavi3ahZ5PrcGQ9nXHN0HzgyyHnk3aDBp8CEwXbNK/mNIDeV2zRvEIVKF556iyL 7dDOeq30gGCTYLPkvIaBhvzHi/NoEV/ueutVaYH6ZNgMvJ5ueKBeEfVdTiRfKfbI FsLkXWqoU/frOSlnNBbh9vyKEupSXw== =y5vN -----END PGP SIGNATURE----- --=-=-=--