unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: "Gábor Boskovits" <boskovits@gmail.com>, 30097@debbugs.gnu.org
Subject: bug#30097: [core-updates] nspr 4.17 not reproducible
Date: Sun, 14 Jan 2018 19:28:58 +0100	[thread overview]
Message-ID: <87fu78e1lh.fsf@fastmail.com> (raw)
In-Reply-To: <CAE4v=pgHOtz21xknxup1xDfq976HnOx8VZUGsJi=KaUTY0LWfQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 347 bytes --]

Gábor Boskovits <boskovits@gmail.com> writes:

> nspr 4.17 is not reproducible.
> Diffoscope output attached.

Thanks for the report!

The attached patch should solve it.  Since there are quite a few
dependent packages, I'd like to push this to a new 'staging' branch that
will be started shortly after the core-updates merge.  WDYT?


[-- Attachment #1.2: 0001-gnu-nspr-Build-reproducibly.patch --]
[-- Type: text/x-patch, Size: 1378 bytes --]

From 9181529d3f2b5c88a3985cbc32ed46e22262858d Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Sat, 13 Jan 2018 18:15:17 +0100
Subject: [PATCH] gnu: nspr: Build reproducibly.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes <https://bugs.gnu.org/30097>.
Reported by Gábor Boskovits <boskovits@gmail.com>.

* gnu/packages/gnuzilla.scm (nspr)[arguments]: Add #:make-flags to prevent
indeterministic timestamps from being recorded.
---
 gnu/packages/gnuzilla.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 61f20a4fd..6ee3133b4 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -268,6 +268,10 @@ in C/C++.")
                                (string-append "LDFLAGS=-Wl,-rpath="
                                               (assoc-ref %outputs "out")
                                               "/lib"))
+       ;; Use fixed timestamps for reproducibility.
+       #:make-flags '("SH_DATE='1970-01-01 00:00:01'"
+                      ;; This is epoch 1 in microseconds.
+                      "SH_NOW=100000")
        #:phases (modify-phases %standard-phases
                   (add-before 'configure 'chdir
                     (lambda _ (chdir "nspr") #t)))))
-- 
2.15.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  parent reply	other threads:[~2018-01-14 18:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-13 16:23 bug#30097: [core-updates] nspr 4.17 not reproducible Gábor Boskovits
2018-01-13 21:07 ` Ludovic Courtès
2018-01-14 18:28 ` Marius Bakke [this message]
2018-01-14 19:35   ` Gábor Boskovits
2018-01-14 19:51     ` Marius Bakke
2018-01-14 20:24       ` Gábor Boskovits
2018-01-16 16:20         ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu78e1lh.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=30097@debbugs.gnu.org \
    --cc=boskovits@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).