From: ludo@gnu.org (Ludovic Courtès)
To: Jack Hill <jackhill@jackhill.us>
Cc: 31726@debbugs.gnu.org
Subject: bug#31726: confirming proposed change
Date: Sat, 09 Jun 2018 22:34:05 +0200 [thread overview]
Message-ID: <87fu1vhf7m.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1806081534020.1480@marsh.hcoop.net> (Jack Hill's message of "Fri, 8 Jun 2018 15:46:46 -0400 (EDT)")
Hi,
Jack Hill <jackhill@jackhill.us> skribis:
>> Jack Hill <jackhill@jackhill.us> skribis:
>>
>>> Sure, I'll give make a path a go. You're thinking that I should try
>>> applying the changes that the commit introduced as part of our package
>>> definition?
>>
>> Yes, either that or use a snapshot of upstream haskell-mode.
>
> I have started workign on a patch implementing the former. I've
> included what I have so far below, but it's not ready to be included
> in the distribution because not all of the tests pass. Maybe this is
> because the one patch shouldn't be applied in issolation and it would
> be bettter to take the snapshot approach?
>
> Otherwise, is what I did with the package revision reasonable?
Yes, definitely.
> From 62ae1a14c48f3d70e6f47ffd6de60a0b9af9d43f Mon Sep 17 00:00:00 2001
> From: Jack Hill <jackhill@jackhill.us>
> Date: Thu, 7 Jun 2018 22:54:12 -0400
> Subject: [PATCH] Patch haskell-mode to remove unused lexical variables
>
> ---
> gnu/packages/emacs.scm | 174 +++++++++++----------
> ...ell-mode-removed-unused-lexical-variables.patch | 42 +++++
> 2 files changed, 131 insertions(+), 85 deletions(-)
> create mode 100644 gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch
You’ll need to add the patch to gnu/local.mk.
> --- /dev/null
> +++ b/gnu/packages/patches/haskell-mode-removed-unused-lexical-variables.patch
Please add a line or two with the URL of the upstream bug report or
patch, and maybe a few words on what the patch is about.
Thank you!
Ludo’.
next prev parent reply other threads:[~2018-06-09 20:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 16:27 bug#31726: haskell-mode fails to build with (at least) Emacs 26.1 Jack Hill
[not found] ` <handler.31726.B.1528217025308.ack@debbugs.gnu.org>
2018-06-05 21:02 ` bug#31726: Acknowledgement (haskell-mode fails to build with (at least) Emacs 26.1) Jack Hill
2018-06-07 16:14 ` Ludovic Courtès
2018-06-07 21:43 ` bug#31726: confirming proposed change Jack Hill
2018-06-08 14:30 ` Ludovic Courtès
2018-06-08 19:46 ` Jack Hill
2018-06-09 20:34 ` Ludovic Courtès [this message]
2018-07-20 19:58 ` bug#31726: Attempt to use git reference for haskell-mode Jack Hill
2018-07-23 8:20 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu1vhf7m.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31726@debbugs.gnu.org \
--cc=jackhill@jackhill.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).