From: Mark H Weaver <mhw@netris.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: 32895@debbugs.gnu.org
Subject: bug#32895: file progress reporter crashes on small files
Date: Thu, 04 Oct 2018 19:28:21 -0400 [thread overview]
Message-ID: <87ftxli962.fsf@netris.org> (raw)
In-Reply-To: <87y3behw3n.fsf@netris.org> (Mark H. Weaver's message of "Thu, 04 Oct 2018 05:58:20 -0400")
I've applied the following temporary workaround to my private branch, to
enable me to work on the IceCat security update.
Mark
--8<---------------cut here---------------start------------->8---
diff --git a/guix/status.scm b/guix/status.scm
index c6956066f..8c6045a7d 100644
--- a/guix/status.scm
+++ b/guix/status.scm
@@ -359,10 +359,11 @@ addition to build events."
(let ((uri (if (string-contains uri "/nar/")
(nar-uri-abbreviation uri)
(basename uri))))
- (display-download-progress uri size
- #:start-time
- (download-start download)
- #:transferred transferred))))))
+ (when transferred ; FIXME XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
+ (display-download-progress uri size
+ #:start-time
+ (download-start download)
+ #:transferred transferred)))))))
(('substituter-succeeded item _ ...)
;; If there are no jobs running, we already reported download completion
;; so there's nothing left to do.
--8<---------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2018-10-04 23:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 14:16 bug#32895: file progress reporter crashes on small files Ricardo Wurmus
2018-10-02 12:34 ` Ludovic Courtès
2018-10-02 14:27 ` Ricardo Wurmus
2018-10-03 21:08 ` Ludovic Courtès
2018-10-04 8:31 ` Ludovic Courtès
2018-10-04 9:58 ` Mark H Weaver
2018-10-04 23:19 ` Mark H Weaver
2018-10-04 23:28 ` Mark H Weaver [this message]
2018-10-04 23:35 ` Mark H Weaver
2018-10-08 12:23 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftxli962.fsf@netris.org \
--to=mhw@netris.org \
--cc=32895@debbugs.gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).