From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Sample Subject: bug#35068: GDM crashes when it cannot find any .desktop files Date: Fri, 26 Apr 2019 14:32:40 -0400 Message-ID: <87ftq47h2v.fsf@ngyro.com> References: <87lg0um9qb.fsf@gnu.org> <20190420170649.30c05dbd@scratchpost.org> <20190421113749.0439cbc9@scratchpost.org> <87v9z72k3p.fsf@gnu.org> <87tvel7we1.fsf@ngyro.com> <87imv1nq47.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:33639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK5ei-0004iI-AQ for bug-guix@gnu.org; Fri, 26 Apr 2019 14:33:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hK5eh-00063h-A7 for bug-guix@gnu.org; Fri, 26 Apr 2019 14:33:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hK5eh-00063b-6X for bug-guix@gnu.org; Fri, 26 Apr 2019 14:33:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hK5eh-0005aG-30 for bug-guix@gnu.org; Fri, 26 Apr 2019 14:33:03 -0400 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-Reply-To: <87imv1nq47.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 26 Apr 2019 10:10:48 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35068-done@debbugs.gnu.org, 35377-done@debbugs.gnu.org Hi Ludo and Danny, Ludovic Court=C3=A8s writes: > Hello, > > Timothy Sample skribis: > >> There are two workarounds. The first is to keep Danny=E2=80=99s patch a= s-is, >> but add logic to =E2=80=9Cxinitrc=E2=80=9D so that it only uses =E2=80= =9C~/.xsession=E2=80=9D when >> passed =E2=80=9Ccustom=E2=80=9D as an argument (it=E2=80=99s kinda magic= , but it seems to be a >> common convention). I have a slight preference for this option, because >> it makes the whole =E2=80=9C~/.xsession=E2=80=9D thing more explicit. H= owever, it would >> break other DMs that don=E2=80=99t install a =E2=80=9Ccustom.desktop=E2= =80=9D. Maybe we could >> integrate it into all DMs at the service level. >> >> The quicker workaround is to keep the current logic, and install the >> following with GDM: >> >> [Desktop Entry] >> Encoding=3DUTF-8 >> Type=3DApplication >> Name=3DFail >> Comment=3DThis session always fails. >> NoDisplay=3Dtrue >> Exec=3Dfalse >> >> This way, GDM fails cleanly when there are no =E2=80=9C.desktop=E2=80=9D= files. It >> doesn=E2=80=99t show up in the list, either (=E2=80=9CNoDisplay=3Dtrue= =E2=80=9D), so everything >> just kinda works as expected without any visible changes. > > I have a slight preference for the hack you propose Timothy, at least in > the short term, because it seems less likely to break anything than > fiddling with =E2=80=9CExec=3Dcustom=E2=80=9D and all that. > > Anyway, it=E2=80=99d be great if one of you could push a fix by 1.0. :-) Pushed as 8caa458953eeac783c73a0e5aaa72842fe3914c9. I=E2=80=99m closing the bug and the patch. If we want to change the =E2=80= =9Cxinitrc=E2=80=9D script to understand =E2=80=9Ccustom=E2=80=9D, we can start a new discussio= n to figure out the best way to do it after 1.0. -- Tim