From mboxrd@z Thu Jan 1 00:00:00 1970 From: mike@rohleder.de Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Date: Tue, 10 Mar 2020 17:03:14 +0100 Message-ID: <87ftegqjst.fsf_-_@rohleder.de> References: <20200309104242.GH1423@E5400> <20200309235402.24941-1-mike@rohleder.de> <20200310085601.GR1423@E5400> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:55419) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBhV9-0004Oz-8Z for bug-guix@gnu.org; Tue, 10 Mar 2020 12:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBhV8-00088N-9K for bug-guix@gnu.org; Tue, 10 Mar 2020 12:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47197) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBhV8-00087Y-6X for bug-guix@gnu.org; Tue, 10 Mar 2020 12:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBhV8-0003nP-0p for bug-guix@gnu.org; Tue, 10 Mar 2020 12:13:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: (Jack Hill's message of "Tue, 10 Mar 2020 10:50:57 -0400 (EDT)") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Jack Hill Cc: 25201-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Jack, Jack Hill writes: > I'm trying to follow along, and learn some things about making Guix > packages. One question I have after seeing this change is how did you > decide whether to make this change in the source definition (with a > patch or a snippet) or in a phase during the build? Well, I saw the substitute* of a #include header (fix-libspeechd-include) in the phase, but the removing of dirs in the source definition and I thought, ok, it might make more sense this way. (because, eg, the phase names (fix-libspeechd-include, fix-statistic-gathering-default etc) could be printed in the log etc) This decition was more a "it feels better" than knowledge, because I'm new to guix and scheme and love to learn (by doing) ;) Regards mike =2D-=20 I have seen the needle and the damage done and every junkie is like a setting sun. -- Neil Young --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl5nukIACgkQfHr/vv7y yyVL0Af+I5j8yVf8oA+CKqyqLRcNWkziPbvncl0myOpQVFBx/w3pe/XeHvoOTAky BWmecUZpSCHJaG+XXZJIYkJmDASHl6v1+kI+eEq9CVIJqeSik0qwHsijj643F2m+ oCvFRz65zbHz2PI+OJNV6XySe2k9ZH2l03gOv07yXb2EAPK4SUc+P2ScadDs3Odu IcYTW/lhkoXf/8o9UDqGTsQFqoBHoSWmEja9DMVkmR9/NscuGT35MccxphTnYFBb u8zeSUQUROqB+XoahYTwO+Mx4s9V/Yly1dDTkH8+g1o3va5+MghMLeeVMZHxt6pF Li+1Csd+1HbaExheQGGKMw19djG3Ag== =zHj6 -----END PGP SIGNATURE----- --=-=-=--