From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cB0yNrRs215GJgAA0tVLHw (envelope-from ) for ; Sat, 06 Jun 2020 10:15:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2HzdMbRs217LVAAAbx9fmQ (envelope-from ) for ; Sat, 06 Jun 2020 10:15:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 596469404E2 for ; Sat, 6 Jun 2020 10:15:16 +0000 (UTC) Received: from localhost ([::1]:59718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhVr9-00029P-51 for larch@yhetil.org; Sat, 06 Jun 2020 06:15:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhVqw-00029F-EK for bug-guix@gnu.org; Sat, 06 Jun 2020 06:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39229) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhVqw-0002ZE-32 for bug-guix@gnu.org; Sat, 06 Jun 2020 06:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhVqv-0002u0-T4 for bug-guix@gnu.org; Sat, 06 Jun 2020 06:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41541: [PATCH 3/8] system: Add 'multiboot-modules' field to . Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 06 Jun 2020 10:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41541 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 41541-submit@debbugs.gnu.org id=B41541.159143844511068 (code B ref 41541); Sat, 06 Jun 2020 10:15:01 +0000 Received: (at 41541) by debbugs.gnu.org; 6 Jun 2020 10:14:05 +0000 Received: from localhost ([127.0.0.1]:50775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhVq1-0002sS-Gf for submit@debbugs.gnu.org; Sat, 06 Jun 2020 06:14:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhVpp-0002ri-To for 41541@debbugs.gnu.org; Sat, 06 Jun 2020 06:14:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58713) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhVpj-0002U3-BY; Sat, 06 Jun 2020 06:13:47 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=34704 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jhVph-0007Fh-Ev; Sat, 06 Jun 2020 06:13:45 -0400 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl References: <20200604135914.4499-1-janneke@gnu.org> <20200604135914.4499-4-janneke@gnu.org> <87eeqsmyxy.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Sat, 06 Jun 2020 12:13:43 +0200 In-Reply-To: <87eeqsmyxy.fsf@gnu.org> (Mathieu Othacehe's message of "Sat, 06 Jun 2020 09:32:41 +0200") Message-ID: <87ftb84i3s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41541@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: JcNun18bcFaR Mathieu Othacehe writes: Hello! >> + (mach (if (%current-target-system) >> + ;; A cross-built GNUmach does not work >> + (with-parameters ((%current-system "i686-linux") >> + (%current-target-system #f)) >> + mach) > > Maybe it would make more sense to check if we are on a Hurd system, > rather than just checking for %current-target-system to be set, don't > know. Ah yes. When this IF runs we already checked that we are building a hurd system; this adds two lines leading up to the above snippet (if (operating-system-hurd os) (let* ((mach (operating-system-kernel os)) (mach (if (%current-target-system) ...but that means that this last IF is maybe unnecessarily implicit and only really makes sense by adding/remembering that context. Changed it to (mach (if (and=3D> (%current-target-system) hurd-triplet?) I guess that's friendlier? >> + (libc (if target >> + (with-parameters ((%current-target-system #f)) >> + (cross-libc target)) >> + glibc)) > > In the future, it would be nice to make this think transparent. Anyway, > for now this is the best we can do I think. Yes, I've added a comment ;; TODO: cross-libc has extra patches for the Hurd; ;; remove in next rebuild cycle (cross-libc target)) I have now 8 squash! commits; I'll be resetting wip-hurd-vm just once more before merging, after checking in with Ludovic and re-running some tests. Really looking forward to seeing a Guix Hurd VM hookup-up in bayfront and really start building a Hurd system, mabye we'll see some more people join in. I think that should be (almost?) possible after merging, right? Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com