From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eM5QHVvBGl9QUgAA0tVLHw (envelope-from ) for ; Fri, 24 Jul 2020 11:09:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sLnmGFvBGl//GgAAbx9fmQ (envelope-from ) for ; Fri, 24 Jul 2020 11:09:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 154A1940653 for ; Fri, 24 Jul 2020 11:09:11 +0000 (UTC) Received: from localhost ([::1]:41758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyvZd-0003cM-F9 for larch@yhetil.org; Fri, 24 Jul 2020 07:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyvZW-0003cC-UA for bug-guix@gnu.org; Fri, 24 Jul 2020 07:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jyvZW-0006Oe-Kt for bug-guix@gnu.org; Fri, 24 Jul 2020 07:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jyvZW-0008Sw-FA for bug-guix@gnu.org; Fri, 24 Jul 2020 07:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42504: guix refresh --update fails for Rust packages Resent-From: Alexandru-Sergiu Marton Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 24 Jul 2020 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42504 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Danny Milosavljevic Received: via spool by 42504-submit@debbugs.gnu.org id=B42504.159558894032534 (code B ref 42504); Fri, 24 Jul 2020 11:09:02 +0000 Received: (at 42504) by debbugs.gnu.org; 24 Jul 2020 11:09:00 +0000 Received: from localhost ([127.0.0.1]:46971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyvZT-0008Se-SH for submit@debbugs.gnu.org; Fri, 24 Jul 2020 07:09:00 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jyvZQ-0008SM-2y for 42504@debbugs.gnu.org; Fri, 24 Jul 2020 07:08:58 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 92341240103 for <42504@debbugs.gnu.org>; Fri, 24 Jul 2020 13:08:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.ro; s=2017; t=1595588929; bh=x03+a5yGTlG4ny7J5UrVia2oUweHmR8BaZrD/5qMBWQ=; h=From:To:Cc:Subject:Date:From; b=gSNljTXmEdyolILukc7+RZfKzQ/ZZfkjRjLSZCv6K2wJiqN1YXUbJ1x7qPxs3MRHD p9faAhTHuEFEDgGB7zjbxNe/eZ9xJaPfQzbxARBPIGiMeyXfxl2RWHYEh+tRWcTjy1 D6Psp7eKWm0suYqz6wreytYg66HPG4DwmxmLXcegkukJ+OBuYWjlhOs/UN+nbr78UL U1gLifhapJhlZOuepzOmaSqxRyrZ7gRudoSilvwLEJN/xUl9l2oQvZlkf6lVsrNmcX ZONFqVvEVcW08kVg3pS5mMpId+wJMzVwhEYowxst5z9QTevkWXth2VXPptypWkPx9I M51Ude3tHAroQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BCmfS6ckSz6tm6; Fri, 24 Jul 2020 13:08:48 +0200 (CEST) From: Alexandru-Sergiu Marton References: <87r1t11iym.fsf@posteo.ro> <20200724112330.4891eb0a@scratchpost.org> Date: Fri, 24 Jul 2020 14:08:45 +0300 In-Reply-To: <20200724112330.4891eb0a@scratchpost.org> (Danny Milosavljevic's message of "Fri, 24 Jul 2020 11:23:30 +0200") Message-ID: <87ft9h1876.fsf@posteo.ro> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42504@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.ro header.s=2017 header.b=gSNljTXm; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.ro (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: ejnwBE6LmXs+ Danny Milosavljevic writes: > And guix repl says: > > scheme@(guix-user)> ,use (guix utils) > scheme@(guix-user)> (file-extension "https://crates.io/api/v1/crates/inst= ant/0.1.2/download") > $1 =3D #f > > But the case #f is not handled in the code above--which is why it doesn't= work. > > Could you test the following fix? > > diff --git a/guix/upstream.scm b/guix/upstream.scm > index 70cbfb45e8..31bd6faea4 100644 > --- a/guix/upstream.scm > +++ b/guix/upstream.scm > @@ -369,7 +369,7 @@ SOURCE, an ." > (let*-values (((archive-type) > (match (and=3D> (package-source package) origin-uri) > ((? string? uri) > - (let ((type (file-extension (basename uri)))) > + (let ((type (or (file-extension (basename uri)) "= "))) > ;; Sometimes we have URLs such as > ;; "https://github.com/=E2=80=A6/tarball/v0.1",= in which case > ;; we must not consider "1" as the extension. This fixes the issue, thanks! -- Sergiu