From: Mark H Weaver <mhw@netris.org>
To: Efraim Flashner <efraim@flashner.co.il>,
Mike Rosset <mike.rosset@gmail.com>
Cc: 43232@debbugs.gnu.org
Subject: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14.
Date: Tue, 15 Sep 2020 16:39:25 -0400 [thread overview]
Message-ID: <87ft7ibwpz.fsf@netris.org> (raw)
In-Reply-To: <20200915062139.GF17272@E5400>
Efraim Flashner <efraim@flashner.co.il> writes:
> On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote:
>> * gnu/packages/audio.scm (jack-2): Update to 1.9.14.
>> [arguments]: new 'declare-for-int phase after unpack that declares 'i in the
>> for initialize statement. Add -lstdc++ to LDFLAGS 'set-linkflags phase
>> ensures -lstdc++ is at the tail.
[...]
>> @@ -2047,8 +2047,18 @@ synchronous execution of all clients, and low latency operation.")
>> "--alsa")
>> #:phases
>> (modify-phases %standard-phases
>> + (add-after 'unpack 'declare-for-int
>> + (lambda _
>> + ;; Declare the for loop i incrementer.
>> + (substitute* "dbus/sigsegv.c"
>> + (("for\\(i = 0") "for(int i = 0"))
>> + #t))
>
> Any chance of an upstream bug number or something for this? It seems
> like the type of thing that might be put into a snippet.
I agree that somehow this fix should be in the 'origin', so that this
fix will be in the output of "guix build --source". However, I'd go
further and suggest that it should be a patch instead of a call to
'substitute*'.
Although patches are larger and a bit more work to create, they are far
more robust. When this bug is eventually fixed upstream, a patch to fix
it will begin raising an error, alerting us that it's time to remove it.
In contrast, a call to 'substitute*' will silently start doing nothing,
and may easily be forgotten. To make matters worse, a future version of
jack-2 might add another 'for' loop in that file, matching the same
pattern but where it is important that 'i' _not_ be initialized to 0.
This 'substitute*' call, likely vestigial by that time but long since
forgotten, could start silently introducing a new bug.
What do you think?
Thanks,
Mark
next prev parent reply other threads:[~2020-09-15 20:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 3:53 bug#43232: jack2 fails to build on aarch64 Vitaliy Shatrov
2020-09-06 8:58 ` Andreas Enge
2020-09-06 10:02 ` Andreas Enge
2020-09-06 13:46 ` Mike Rosset
2020-09-15 4:25 ` bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14 Mike Rosset
2020-09-15 6:21 ` Efraim Flashner
2020-09-15 7:29 ` Mike Rosset
2020-09-15 20:39 ` Mark H Weaver [this message]
2020-09-15 20:48 ` Mark H Weaver
2020-09-15 22:28 ` Mike Rosset
2020-09-15 22:45 ` Mark H Weaver
2020-09-15 21:07 ` Mike Rosset
2020-09-15 7:48 ` bug#43232: [PATCH 2/2] gnu: jack2: 'declare-for-int phase no longer required Mike Rosset
2020-09-15 8:02 ` Andreas Enge
2020-09-15 8:37 ` Mike Rosset
2020-09-15 18:48 ` Andreas Enge
2020-09-15 19:16 ` Mike Rosset
2020-09-15 8:33 ` bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14 Mike Rosset
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft7ibwpz.fsf@netris.org \
--to=mhw@netris.org \
--cc=43232@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=mike.rosset@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).