From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GGJ9Etr4x18hHQAA0tVLHw (envelope-from ) for ; Wed, 02 Dec 2020 20:28:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GK41Dtr4x18YBAAAbx9fmQ (envelope-from ) for ; Wed, 02 Dec 2020 20:28:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C03129404FF for ; Wed, 2 Dec 2020 20:28:09 +0000 (UTC) Received: from localhost ([::1]:33284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkYjQ-0000Eh-P9 for larch@yhetil.org; Wed, 02 Dec 2020 15:28:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkYjK-0000ES-Ce for bug-guix@gnu.org; Wed, 02 Dec 2020 15:28:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kkYjK-0007Mv-4k for bug-guix@gnu.org; Wed, 02 Dec 2020 15:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kkYjK-0000nM-23 for bug-guix@gnu.org; Wed, 02 Dec 2020 15:28:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#23874: [PATCH 1/2] profiles: Remove duplicates in manifest transactions. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 02 Dec 2020 20:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23874 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Prikler , 23874@debbugs.gnu.org Received: via spool by 23874-submit@debbugs.gnu.org id=B23874.16069408332980 (code B ref 23874); Wed, 02 Dec 2020 20:28:02 +0000 Received: (at 23874) by debbugs.gnu.org; 2 Dec 2020 20:27:13 +0000 Received: from localhost ([127.0.0.1]:37499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkYiX-0000m0-DQ for submit@debbugs.gnu.org; Wed, 02 Dec 2020 15:27:13 -0500 Received: from world.peace.net ([64.112.178.59]:37708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkYiV-0000li-DW for 23874@debbugs.gnu.org; Wed, 02 Dec 2020 15:27:12 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkYiP-0007pH-0e; Wed, 02 Dec 2020 15:27:05 -0500 From: Mark H Weaver In-Reply-To: <20201202132244.30694-1-leo.prikler@student.tugraz.at> References: <20201202132244.30694-1-leo.prikler@student.tugraz.at> Date: Wed, 02 Dec 2020 15:26:15 -0500 Message-ID: <87ft4oeyyl.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.28 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: C03129404FF X-Spam-Score: -2.28 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: jg7HNMUpCNfP Hi, Leo Prikler writes: > * guix/profiles.scm (manifest-transaction-effects): Delete duplicates in > install and remove. Let multiple upgrades and downgrades shadow previous > transactions of the same kind. > --- > guix/profiles.scm | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/guix/profiles.scm b/guix/profiles.scm > index 1b15257210..99b7dbf299 100644 > --- a/guix/profiles.scm > +++ b/guix/profiles.scm [...] > @@ -740,10 +743,10 @@ replace it." > (loop rest > (if previous install (cons entry install)) > (if (and previous newer?) > - (alist-cons previous entry upgrade) > + (assoc-set! upgrade previous entry) > upgrade) > (if (and previous (not newer?)) > - (alist-cons previous entry downgrade) > + (assoc-set! downgrade previous entry) > downgrade))))))) We should avoid mutating existing list structure, as done above with 'assoc-set!'. Thanks, Mark