unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 50597@debbugs.gnu.org
Subject: bug#50597: different fixed-output when using ’--with-source’ transformation
Date: Sat, 18 Sep 2021 18:06:38 +0200	[thread overview]
Message-ID: <87fsu1uaup.fsf@gnu.org> (raw)
In-Reply-To: <86zgsecrzv.fsf@gmail.com> (zimoun's message of "Wed, 15 Sep 2021 07:44:36 +0200")

Hello!

zimoun <zimon.toutoune@gmail.com> skribis:

> Why the store item of source tarball is it different when applying the
> transformation?
>
> Maxime provided a clue [1].

Maxime is right: ‘--with-source’ passes #:recursive? #t unconditionally,
whereas it’s usually #f for a ‘url-fetch’ kind of URI.

What we could do is make it #t if and only if the URL denotes a local
file and that file is a directory.  I think that would achieve what you
want without any observable regression in practice.

WDYT?

Thanks,
Ludo’.




  reply	other threads:[~2021-09-18 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  5:44 bug#50597: different fixed-output when using ’--with-source’ transformation zimoun
2021-09-18 16:06 ` Ludovic Courtès [this message]
2021-09-18 17:35   ` Maxime Devos
2021-09-21  7:40   ` zimoun
2021-09-22 10:25     ` Ludovic Courtès
2021-10-13  9:31       ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsu1uaup.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=50597@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).