unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 56334@debbugs.gnu.org
Subject: bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?
Date: Fri, 01 Jul 2022 16:40:44 +0000	[thread overview]
Message-ID: <87fsjkzsl4.fsf@kitej> (raw)
In-Reply-To: <87o7y8x544.fsf@ambrevar.xyz>

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Hi Guillaume,
>
> I gave it a go and your suggestion indeed cuts it for cleavir and
> cl-gamepad.
>
> It did not fix it for the tests though.
>
> I did some more testing, and this is what I found out on one of the
> failing systems (cl-reexport): from a --pure sbcl repl, if I load the
> .asd files manually then run test-system, I can reproduce the issue.
>
> However, if I run
>
>  (asdf:initialize-source-registry
>     `(:source-registry (:tree ,(uiop:getcwd))
>                        :inherit-configuration))
>   (asdf:test-system :cl-reexport)
>
> then it works!
>
> In other words, I believe that `asdf:load-asd' is yet another under-used
> ASDF function, and we should probably go with the officially recommended
> way, namely adding the source folder to the ASDF registry.
>
> Thoughts?
>
> I'll try it out then send a patch.
>
> Cheers!

I think using the 'initialize-source-registry' technique instead of
'load-asd' would also make the '#:asd-files' and '#:test-asd-file'
arguments of the build system unnecessary, so they could be removed.




  reply	other threads:[~2022-07-01 16:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 10:16 bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system? Pierre Neidhardt
2022-07-01 11:13 ` Guillaume Le Vaillant
2022-07-01 11:45   ` Pierre Neidhardt
2022-07-01 12:22     ` Guillaume Le Vaillant
2022-07-01 14:46       ` Pierre Neidhardt
2022-07-01 16:40         ` Guillaume Le Vaillant [this message]
2022-07-01 17:07           ` Pierre Neidhardt
2022-07-02 10:17             ` Pierre Neidhardt
2022-07-03 10:19               ` Guillaume Le Vaillant
2022-07-04 15:18                 ` Pierre Neidhardt
2022-07-04 19:57                   ` Pierre Neidhardt
2022-07-05  8:56                     ` Pierre Neidhardt
2022-07-17 16:19                     ` Pierre Neidhardt
2022-08-03 14:49                       ` Guillaume Le Vaillant
2022-08-04 14:01                         ` Pierre Neidhardt
2022-07-01 14:30 ` Liliana Marie Prikler
2022-07-01 14:43   ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsjkzsl4.fsf@kitej \
    --to=glv@posteo.net \
    --cc=56334@debbugs.gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).