From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yAeSFibe6WLwyQAAbAwnHQ (envelope-from ) for ; Wed, 03 Aug 2022 04:32:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qJSsFibe6WKWPgAA9RJhRA (envelope-from ) for ; Wed, 03 Aug 2022 04:32:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5177BD6F for ; Wed, 3 Aug 2022 04:32:05 +0200 (CEST) Received: from localhost ([::1]:47468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJ4B2-0008Gc-5T for larch@yhetil.org; Tue, 02 Aug 2022 22:32:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ494-000732-R2 for bug-guix@gnu.org; Tue, 02 Aug 2022 22:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55865) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJ494-0007eC-HP for bug-guix@gnu.org; Tue, 02 Aug 2022 22:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJ494-0004IK-D8 for bug-guix@gnu.org; Tue, 02 Aug 2022 22:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56900: phoronix-test-suite downloads nonfree software (+ question on collaboration with Parabola on this package) Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 03 Aug 2022 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56900 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Denis 'GNUtoo' Carikli Cc: 56900@debbugs.gnu.org Received: via spool by 56900-submit@debbugs.gnu.org id=B56900.165949374716394 (code B ref 56900); Wed, 03 Aug 2022 02:30:02 +0000 Received: (at 56900) by debbugs.gnu.org; 3 Aug 2022 02:29:07 +0000 Received: from localhost ([127.0.0.1]:45609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ48A-0004GL-IP for submit@debbugs.gnu.org; Tue, 02 Aug 2022 22:29:06 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]:39742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ488-0004Fk-7T for 56900@debbugs.gnu.org; Tue, 02 Aug 2022 22:29:04 -0400 Received: by mail-qk1-f180.google.com with SMTP id m7so11963289qkk.6 for <56900@debbugs.gnu.org>; Tue, 02 Aug 2022 19:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=n/SHgho8nGAQc9fUTzMRyKGg92hSl8y46SxLLCdhzpg=; b=UW0X1LqlWjhVoYS9P8jG+P029IB9hlMopx0a57sLbQAg6dBcYk0ICQMDrj67rNYiXu 7Mobbsj8LbbRCb0+Wf8IqWxF3S/accmFbThUHmEcbWNNrZriIn/vgjVum+7tRaDevdQb +Rk+1Adn49Dr8hVvCBZXIJBBnfuJMYew1aLzaKWBwUvHjaOgVhmkBTcPrkksApx9XZl9 czYMGPF1Nf+/HJ6n0x4l70uzhzHTAPeBrrMqQARQOIshAlKeftGaggQwh/J0tdk9vFms jCAKZveZu1GQpvz/C2jqYqXoYC3AMuBQAjO3l4M7zbthgNwjVwTbRBP/+zcO1KnkUvCQ tWZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=n/SHgho8nGAQc9fUTzMRyKGg92hSl8y46SxLLCdhzpg=; b=3ZByKiPIBXdfbEeG1KkneeDrxYVzFaQynxNYMdVkERb53qHliagvUa2uhV3EBcMO2j m513fd6ak1kbGh1f5nq3b1zy/9Lf0ilK7VWIArtPgJoads+b2fNZAWMVQkJj9T7jUAmh /s/Glz7YOYPuMpk9Y1iws2upzgw8MOh6Co/VF3tP4ub5m/AA+3+M6Ruh/ftJlSSbmJE4 X4ANZAdOMawXjl+78wQIyB2gpowhGLINBTB8I0rmA2QyiwVA5fB4zQ4U2o4k6mp0/5M0 0Tpg5/OPJV4aHmgITCuqFEw0v7xR/Zx7DubdqH76Lq2nTDiF8vAvqkVY+M3K2EWtqsJ6 agOA== X-Gm-Message-State: ACgBeo1+atqBE3XjyuHazadf63idHJGapeUVFvP/le0Ho6qhI9yKnO3S TnSAdZMsc8UpCo7nsj1FrwCsC1me52o= X-Google-Smtp-Source: AA6agR5UJToS7j5Ida5sIKW/2bzeYnXwdT1ctAzUuPai9MG9jNhx497xD8XgXKmwu/B0z0CRuHGz/g== X-Received: by 2002:a05:620a:1a18:b0:6b8:cf40:571c with SMTP id bk24-20020a05620a1a1800b006b8cf40571cmr3749191qkb.435.1659493738305; Tue, 02 Aug 2022 19:28:58 -0700 (PDT) Received: from hurd (dsl-151-182.b2b2c.ca. [66.158.151.182]) by smtp.gmail.com with ESMTPSA id s6-20020a05620a0bc600b006b5f68bc106sm11638631qki.110.2022.08.02.19.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 19:28:57 -0700 (PDT) From: Maxim Cournoyer References: <20220803012745.2d5e24de@primary_laptop> Date: Tue, 02 Aug 2022 22:28:56 -0400 In-Reply-To: <20220803012745.2d5e24de@primary_laptop> (Denis Carikli's message of "Wed, 3 Aug 2022 01:27:45 +0200") Message-ID: <87fsiejc0n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659493926; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=n/SHgho8nGAQc9fUTzMRyKGg92hSl8y46SxLLCdhzpg=; b=Y8U8G9f31i/DK/XqNoj4ismwxcrmPfeIzs07cjPDTRBw6g+Ce1EOFDNrz0AiYBVWjB3TUR IJ13eH/Jk0LKA/xP1pQAQiGHgbzZ8VIoui3/HC5l1S9rJPpbKThtVYjfLJzRBPOjfWnhjU LN08v+ssy/oCZmEL18KNJGjbpxCok5rlYATchMRBlxgzdfV7/AbAs9BfTh8N5aM/3SK+la LSwGui4MmChupR5YxHm3y2z3FZEcsQ9YC6wK7PImqMNwqXfZjigd1KFV9hXmoM/wQ+7SLK qLU+0wmxg6Wxt/5xyPEMfwd5EAIdP35RPqFH/nn5dEMl+jO24Gf468dIoEet/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659493926; a=rsa-sha256; cv=none; b=F2Qp4iZzi77oLmGU+EYkSf/Un+KcZ5eaPk8RoS2F20C5CP4A3bFYjAejwQPUS0qORT2pLD EBCVAuCV0np+jwIOgH/dTdwRD1XJx0NEzi4qrFHF1yPJSywJWwmJ3BhVCTvS2vAdahmeFF 5ZkQQ9UFjShRjaZeSiHapeEKI0opar8nEzmTNbcudXwIVcj+yPKDeTvnGi3lRdxKiqdlGZ fUAT7IVTBZe5obY+XcsQVTkIEcNljj4kdzq9ytoz8mnf6Dcjgm/XMKgPClyOSy+Cl+YWxN lWCmLSwT419ZNrFMqbZ9zxygaBolkcc8P4PdxqEzCCF+BQuNi1M81pmf1LpV0w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=UW0X1Lql; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=UW0X1Lql; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D5177BD6F X-Spam-Score: 4.78 X-Migadu-Scanner: scn0.migadu.com X-TUID: o51Mav2EknX7 Hi Denis, Denis 'GNUtoo' Carikli writes: > Hi, > > Thanks a lot for working on having a recent FSDG compliant versions of > phoronix-test-suite. > > I've found a minor issue with phoronix-test-suite and I've a couple of > questions to help synchronize between Parabola and Guix to prevent > accidental installation of nonfree software. Thanks for reaching out! > Nonfree software downloaded by phoronix-test-suite: > --------------------------------------------------- > According to Debian, Linux has the following nonfree files: >> Documentation/netlabel/draft-ietf-cipso-ipsecurity-01.txt >> arch/powerpc/platforms/8xx/micropatch.c >> drivers/media/usb/dvb-usb/af9005-script.h drivers/media/i2c/vs6624.c >> drivers/net/appletalk/cops* >> drivers/video/fbdev/nvidia >> drivers/video/fbdev/riva > > The GNU project also mention that ("nonfree blobs are shipped with > Linux, the kernel") in the list of distros that are not FSDG > compliant[1]. > > When running 'phoronix-test-suite test build-linux-kernel' (and > selecting Yes(Y) to install the test), phoronix-test-suite downloads > a tarball of Linux. > > So I assume that the tarball downloaded also have nonfree software like > arch/powerpc/platforms/8xx/micropatch.c. So we also need to filter-out > two tests (to keep being FSDG compliant): >> pts/build-linux-kernel >> pts/unpack-linux > > As I understand, the other build should be fine. The test is probably marked as free (as in freedom) by the metadata included in the test; we should rectify that in a source snippet and open an issue upstream so that the correct metadata gets added. Looking a it, the unpack-firefox would fall in the same category I believe. > Question on the package description and collaborating with Parabola: > -------------------------------------------------------------------- > If I run 'phoronix-test-suite list' on a fresh Guix installation, it > lists nonfree software like BioShock Infinite, Hitman, which are games > that have not been released under free licenses (according to > Wikipedia). I confirm: $ phoronix-test-suite list-all-tests | grep -iE '(hitman|bioshock)' pts/bioshock-infinite BioShock Infinite Graphics pts/hitman HITMAN Graphics And the reason why: --8<---------------cut here---------------start------------->8--- $ grep License $(guix build phoronix-test-suite)/ob-cache/test-profiles/pts/hitman-1.0.1/test-definition.xml Free $ grep License /gnu/store/bdjf3g5c0xv0hhygag1rwjsvq11y7j1h-phoronix-test-suite-10.8.3/share/phoronix-test-suite/ob-cache/test-profiles/pts/bioshock-infinite-1.0.1/test-definition.xml Free --8<---------------cut here---------------end--------------->8--- We definitely should report these upstream, if they haven't been fixed yet (there's a separate repository for the test metadata). > If it didn't download any nonfree games, we could update the package > description to explain how this FSDG compliance is done to not make > users afraid and prevent invalid bug reports. Good idea. > I also saw there is a python script[2] that somehow is supposed to take > care of FSDG compliance. How does it work in practice? phoronix-test-suite comes with the test metadata so that it can at list them offline upon first use. Normally, it fetches updates of this metadata but this gets disabled in our packaging of it, so only our cleaned up offline metadata gets used. So the Python script takes care of pruning nonfree tests from the metadata, based on the metadata of the tests themselves (normally their 'License' field is set to 'Free' for free software). I hope that helps clearing how it works. Would you like to try preparing a snippet patch turning the above 'Free' into 'Proprietary' or the likes so that the Python script can remove them? Otherwise I can look into it. Thanks, Maxim