unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Dr. Arne Babenhauserheide" <arne_bab@web.de>
To: 61126@debbugs.gnu.org
Subject: bug#61126: [patch] fix: tcsh fails to build if guix builders have niceness 5 or more
Date: Sat, 28 Jan 2023 23:14:03 +0100	[thread overview]
Message-ID: <87fsbul2xw.fsf@web.de> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 181 bytes --]

Hi,

guix build tcsh failed in my guix build when running
guix build --check tcsh

The attached patch disables the test that fails when the niceness of
guix builders is 5 or more.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-tcsh-comment-out-test-of-nice-with-nice-guix-bui.patch --]
[-- Type: text/x-patch, Size: 1445 bytes --]

From 193dca1b55b68aa883c3ed8b28bf19e9527fa065 Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide <arne_bab@web.de>
Date: Sat, 28 Jan 2023 22:29:39 +0100
Subject: [PATCH] gnu: tcsh: comment out test of nice with nice guix builder

* gnu/packages/patches/tcsh-fix-autotest.patch: comment out test of nice. To
  reproduce:
  guix shell tcsh -- nice -n 4 tcsh -c "nice echo 1" # works
  guix shell tcsh -- nice -n 5 tcsh -c "nice echo 1" # breaks
---
 gnu/packages/patches/tcsh-fix-autotest.patch | 29 ++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/patches/tcsh-fix-autotest.patch b/gnu/packages/patches/tcsh-fix-autotest.patch
index 9f5790641b..252560dbb2 100644
--- a/gnu/packages/patches/tcsh-fix-autotest.patch
+++ b/gnu/packages/patches/tcsh-fix-autotest.patch
@@ -1,3 +1,32 @@
+--- tests/commands.at
++++ tests/commands.at
+@@ -890,15 +890,16 @@
+ TCSH_UNTESTED([newgrp])
+ 
+ 
+-AT_SETUP([nice])
+-
+-# Nothing really tested
+-AT_CHECK([tcsh -f -c 'nice set var=1; echo $?var'], ,
+-[0
+-])
+-
+-
+-AT_CLEANUP
++# XXX This test fails if the Guix worker has a nice value >= 5
++# AT_SETUP([nice])
++# 
++# # Nothing really tested
++# AT_CHECK([tcsh -f -c 'nice -n +1 set var=1; echo $?var'], ,
++# [0
++# ])
++# 
++# 
++# AT_CLEANUP
+ 
+ 
+ AT_SETUP([nohup])
+
 --- tests/commands.at
 +++ tests/commands.at
 @@ -921,26 +921,27 @@ AT_CLEANUP
-- 
2.39.1


[-- Attachment #1.3: Type: text/plain, Size: 101 bytes --]


Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1125 bytes --]

                 reply	other threads:[~2023-01-28 22:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsbul2xw.fsf@web.de \
    --to=arne_bab@web.de \
    --cc=61126@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).