From: Simon Tournier <zimon.toutoune@gmail.com>
To: 65979@debbugs.gnu.org
Subject: bug#65979: incorrect “guix hash” for FastQC
Date: Tue, 26 Sep 2023 15:00:25 +0200 [thread overview]
Message-ID: <87fs313x92.fsf@gmail.com> (raw)
In-Reply-To: <87v8ccd7oy.fsf@gmail.com> (Simon Tournier's message of "Thu, 14 Sep 2023 18:46:05 +0200")
Hi,
On Thu, 14 Sep 2023 at 18:46, Simon Tournier <zimon.toutoune@gmail.com> wrote:
> $ guix hash -rx $(guix build /gnu/store/8gxx74w8pa0fx74lx1ka654rhyyr51cs-fastqc-0.11.9-checkout.drv)
> 0jyk90kg6s62w3dn6qjx9nrawjs12qx172lii0yxbvsfylhnx479
>
> Oh, it is not the expected result! Instead, I have to omit the option
> ’-x’:
>
> $ guix hash -r $(guix build /gnu/store/8gxx74w8pa0fx74lx1ka654rhyyr51cs-fastqc-0.11.9-checkout.drv)
> 00y9drm0bkpxw8xfl8ysss18jmnhj8blgqgr6fpa58rkpfcbg8qk
[...]
> $ git clone https://github.com/s-andrews/FastQC
> $ git -C FastQC checkout v0.11.9
> $ guix hash -rx FastQC
> 0jyk90kg6s62w3dn6qjx9nrawjs12qx172lii0yxbvsfylhnx479
[...]
> $ mv FastQC/.git bye-bye
> $ guix hash -r FastQC
> 00y9drm0bkpxw8xfl8ysss18jmnhj8blgqgr6fpa58rkpfcbg8qk
[...]
> Any idea?
The issue is from .svn folders.
--8<---------------cut here---------------start------------->8---
$ find $(guix build /gnu/store/8gxx74w8pa0fx74lx1ka654rhyyr51cs-fastqc-0.11.9-checkout.drv) \
-type d -name ".svn" -print
/gnu/store/5dyvjgylwiixhp8z9a08rnddh53h4cdx-fastqc-0.11.9-checkout/Help/1 Introduction/.svn
/gnu/store/5dyvjgylwiixhp8z9a08rnddh53h4cdx-fastqc-0.11.9-checkout/Help/3 Analysis Modules/.svn
/gnu/store/5dyvjgylwiixhp8z9a08rnddh53h4cdx-fastqc-0.11.9-checkout/Help/2 Basic Operations/.svn
--8<---------------cut here---------------end--------------->8---
The option ’-x’ excludes them; see vcs-file? from (guix hash) module,
and let confirm:
$ git clone https://github.com/s-andrews/FastQC
$ git -C FastQC checkout v0.11.9
$ guix hash -rx FastQC
0jyk90kg6s62w3dn6qjx9nrawjs12qx172lii0yxbvsfylhnx479
$ find FastQC -type d -name ".svn" -exec rm -r "{}" \;
$ mv FastQC/.git bye-bye
$ guix hash -r FastQC
0jyk90kg6s62w3dn6qjx9nrawjs12qx172lii0yxbvsfylhnx479
Therefore, we have a discrepancy between “guix hash” command-line and
checksum verification from ’source’ field.
The package definition reads:
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/s-andrews/FastQC")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"00y9drm0bkpxw8xfl8ysss18jmnhj8blgqgr6fpa58rkpfcbg8qk"))
when this hash contains .svn subfolders that are excluded by ’-x’
command-line option.
What do we fix? The procedure vcs-file? or fixed-output computation?
Cheers,
simon
next prev parent reply other threads:[~2023-09-26 13:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 16:46 bug#65979: incorrect “guix hash” for FastQC Simon Tournier
2023-09-26 13:00 ` Simon Tournier [this message]
2023-09-26 13:34 ` Ludovic Courtès
2023-09-26 16:23 ` Simon Tournier
2023-10-01 15:07 ` Ludovic Courtès
2023-10-01 15:24 ` Simon Tournier
2023-10-17 17:56 ` Simon Tournier
2023-09-26 13:29 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs313x92.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=65979@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).