From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id IHkFORcNUmaHtAAAA41jLg (envelope-from ) for ; Sat, 25 May 2024 18:08:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id kEdKMxcNUmYcdAAA62LTzQ (envelope-from ) for ; Sat, 25 May 2024 18:08:55 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=alternativebit.fr header.s=gm1 header.b=cb4CfNg2; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716653335; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=wdNkwpEQJW0e8biPEGvxVvobdzzr8MtGrL1dy2/FxkI=; b=B3/isQGLdfl0duesW6GnCIuF51O+ZlGLVY7kq2JDqcxlQYTkLZxQS8ZpaxOnUi9hlzEEdn lc4z6wK02KxyfqMz2unH2OKGIA5yItFF10LisyyuW3N+uv0H1tuR5WakW3otzPlP/tKrhc /DoYxDaU4UZu58BYUyaXHX3azFRGM8VSG/6HmSF897uXpKN9B8FPass8dWjt5KyuiuZDfQ czn2/DBfCC/a+otPXoc6gquNxak+NegeIi4yHoyTy2zBvKawUJBJc7ZRCNkywnNzVqGE6z 8St/tPcTamuVisn401X428UVxDOjta/C2TS1vUBqIY7EGqFYNC88itq/Sh5LVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=alternativebit.fr header.s=gm1 header.b=cb4CfNg2; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716653335; a=rsa-sha256; cv=none; b=EdnBvMjMqVWIvWBpwUbdeaZas/UK39x/pbQ61J2ZnNYIsQs5FBLlCKsh5eu8X27YgaYabU x0K3cT9wKtp7N/P9O5EUkSDEsBwYNg8B19jwrfW/fzQ8/AX12jauWkuVVAmd6CzYBzAqT8 6aNSfaFs5fW44Ro0hyscqZcDGTEtmy5t/3Ua7z7B2wXUjZ9ID3Nx2Xbt1MH32SUjz9TK/c XhBa3vdaiQfMhN20EkY4qE7WDKNRDK2JHVYQDezffQ9PgSgcI5gzf04pM7Lj99vp1kdb7a 4QN0HnT+cFB1LidZ+avy0imh+rZU11XUyh9ee8TY+UvO3byMZlbhLsDZTaFI5Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0EF4EAB2 for ; Sat, 25 May 2024 18:08:55 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAtw1-000605-Pp; Sat, 25 May 2024 12:07:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAlxW-0000wJ-SA for bug-guix@gnu.org; Sat, 25 May 2024 03:36:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAlxW-0005NN-KL for bug-guix@gnu.org; Sat, 25 May 2024 03:36:54 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAlxd-0006mY-W4 for bug-guix@gnu.org; Sat, 25 May 2024 03:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#71193: Shepherd fails to start a system when given an incorrect form to the start field of any service Resent-From: "Picnoir" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 25 May 2024 07:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71193 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 71193@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171662258825972 (code B ref -1); Sat, 25 May 2024 07:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 May 2024 07:36:28 +0000 Received: from localhost ([127.0.0.1]:41769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAlx6-0006kp-4i for submit@debbugs.gnu.org; Sat, 25 May 2024 03:36:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:52990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAlx1-0006kd-8k for submit@debbugs.gnu.org; Sat, 25 May 2024 03:36:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAlul-00006h-Dw for bug-guix@gnu.org; Sat, 25 May 2024 03:34:03 -0400 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAluj-0004c2-Hk; Sat, 25 May 2024 03:34:03 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id C875420005; Sat, 25 May 2024 07:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alternativebit.fr; s=gm1; t=1716622436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wdNkwpEQJW0e8biPEGvxVvobdzzr8MtGrL1dy2/FxkI=; b=cb4CfNg2+XyhQnm6ldMpAAiX3SQydUCFIo2waAA7TnKd/whtrj1s2jhsvRllLuePw2w+9z Oq23u6DB+dpsyYtL6FYYsQKvWinOZCPRgpWOVX6we8gT8Xy7jcqL0cotgcurfN2VWybkX2 r7HTZziJgEHzVXUfXnrNTwExpCamMVI9KaBnf42oSHLyW38KevczBq8XTokRwmnXU8n2Xg FpRNw3wZnK2THmcqxhYcK3vbFnQjbb3/ABmUyPXcKJAJSCTo7o0cgcGA/IuRZhECmn3lPe LLaqYhA4pCgVJji3+tXqpDZs1FgZmy3v/JydVZL+2W1+Xne+/qaBOVfYTTuPew== From: "Picnoir" Date: Sat, 25 May 2024 09:33:55 +0200 Message-ID: <87fru6uyzg.fsf@alternativebit.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: felix@alternativebit.fr Received-SPF: pass client-ip=2001:4b98:dc4:8::227; envelope-from=picnoir@alternativebit.fr; helo=relay7-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sat, 25 May 2024 12:07:46 -0400 X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -2.65 X-Migadu-Queue-Id: A0EF4EAB2 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -2.65 X-TUID: HiBhlHLS0F1i Hey Guix, I'm facing a pretty annoying Shepherd 0.10.4 bug. If a service start script gets provided an incorrect form, such as an empty quoted list, Shepherd hangs during its early startup and bricks the overall Guix system. I think the following snippet is a good minimal reproducer for this. Add this service to a guix system configuration: --8<---------------cut here---------------start------------->8--- (simple-service 'shepherd-bug-repro shepherd-root-service-type (list (shepherd-service (documentation "shepherd hang minimal repro") (provision '(shepherd-bug-repro)) (requirement '()) (start #~('()))))) u--8<---------------cut here---------------end--------------->8--- =E2=9A=A0 DO NOT BOOT ON A CRITICAL SYSTEM WITH THIS SERVICE, IT'LL BRICK I= T =E2=9A=A0 You can create a VM for this system and start it. The VM hangs after the log line "creating /etc/machine-id...", before any shepherd service gets started. You get the same behaviour if you end up booting by misfortune a "real" system having this service.=20 Instead of having the whole system to freeze, I'd expect shepherd to fail the particular service having an incorrect start form. I'm not sure what's happening here. I did not manage to diagnose this furth= er, the shepherd does not seem to be super chatty at this stage of the boot. Tested on Shepherd 0.10.4 with the Guix revision c5e63e19ac672f9e63fc8ee98fa9a16f978ce19c.