From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#23979: [ER] guix gc should tell how much space it recovered
Date: Fri, 15 Jul 2016 16:33:46 +0200
Message-ID: <87eg6v0y45.fsf@gnu.org>
References: <CAEwRq=o5Z9e03m+3kKGVfyd=hmRaJgLwEMK8gzZDZ9i8U0GQoQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bO4Bn-0007cj-97
	for bug-guix@gnu.org; Fri, 15 Jul 2016 10:34:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bO4Bm-0007wB-B6
	for bug-guix@gnu.org; Fri, 15 Jul 2016 10:34:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40803)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bO4Bm-0007w0-7W
	for bug-guix@gnu.org; Fri, 15 Jul 2016 10:34:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bO4Bm-0005hw-0l
	for bug-guix@gnu.org; Fri, 15 Jul 2016 10:34:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.23979.B23979.146859324021933@debbugs.gnu.org>
In-Reply-To: <CAEwRq=o5Z9e03m+3kKGVfyd=hmRaJgLwEMK8gzZDZ9i8U0GQoQ@mail.gmail.com>
	(Vincent Legoll's message of "Thu, 14 Jul 2016 12:54:18 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 23979@debbugs.gnu.org

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> It already shows:
> note: currently hard linking saves 485.41 MiB
>
> Recovered disk space would nicely complement that.

Indeed.

> Looks like I helped myself out of step 1:
> this is in guix/scripts/gc.scm if I'm not mistaken

Yep, you=E2=80=99re on the right track!

This code calls the =E2=80=98collect-garbage=E2=80=99 procedure, defined in=
 (guix
store).  You=E2=80=99ll see that this procedure returns two values, which a=
re
currently ignored: the name of the items that were removed from the
store, and the number of bytes freed.

Your mission, if you accept it, is to change gc.scm to retrieve this
second value and to display it in a human-friendly way.  :-)

HTH!

Ludo=E2=80=99.