From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#25598: [PATCH] More reproducibility fixes for R. Date: Wed, 8 Mar 2017 12:53:43 +0100 Message-ID: <87efy82ddk.fsf@elephly.net> References: <8737fydyma.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1claBN-00070N-K7 for bug-guix@gnu.org; Wed, 08 Mar 2017 06:55:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1claBK-0003fy-Hf for bug-guix@gnu.org; Wed, 08 Mar 2017 06:55:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:47236) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1claBK-0003fu-Fe for bug-guix@gnu.org; Wed, 08 Mar 2017 06:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1claBK-0003c7-4D for bug-guix@gnu.org; Wed, 08 Mar 2017 06:55:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87bmuafcgg.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Guix-devel , 25598@debbugs.gnu.org Ludovic Courtès writes: > Ricardo Wurmus skribis: > >> attached are more reproducibility fixes for R. Unfortunately, it seems >> that files of type “rdb”, “rdx”, and “rds” are still not reproducible. >> This leaves us with the following files in R that are currently not >> reproducible: > > Could it be that --built-timestamp is not honored for R modules within > R? With these two patches the flag *should* be honoured. I don’t understand yet where the rds differences come from, but I’ll investigate this now. > Do the Debian patches mentioned in #25598 help? R 3.3.2 already includes the patches that were posted on Debian bug #774031. The patch at #782764 is the equivalent of our change to the r-build-system to pass down the flag to R packages. >> From e8cd2114b824ab6fed671c2214956ee22deeaedf Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Thu, 9 Feb 2017 14:34:57 +0100 >> Subject: [PATCH 1/2] gnu: r: Fix syntax for INSTALL_OPTS. >> >> This is a follow-up to commit 4621acfd8272fa93d0530faa5f015b26a194b587. >> >> * gnu/packages/statistics.scm (r)[arguments]: Ensure that >> "--built-timestamp" appears on the same line as the other INSTALL_OPTS. > > So the previous attempt had no effect, right? Yeah, it was not effective and I failed to use “guix build --check” properly (without grafts), so I thought everything was fine already. >> From 95b939f662a29b3cc6973a2fba286f32faf010c1 Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Thu, 9 Feb 2017 15:40:02 +0100 >> Subject: [PATCH 2/2] gnu: r: Fix more reproducibility problems. >> >> * gnu/packages/statistics.scm (r)[arguments]: Patch locations in the >> build system that need special treatment for reproducibility. > > LGTM, thanks! I pushed both to master. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net