From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#25917: [PATCH] file-systems: Factorize file-system-packages.
Date: Fri, 17 Mar 2017 10:03:52 +0100
Message-ID: <87efxwi8av.fsf@gnu.org>
References: <20170316174029.1663-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1conoq-0004ke-GC
	for bug-guix@gnu.org; Fri, 17 Mar 2017 05:05:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1conok-0003TH-UK
	for bug-guix@gnu.org; Fri, 17 Mar 2017 05:05:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33162)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1conok-0003TD-Ra
	for bug-guix@gnu.org; Fri, 17 Mar 2017 05:05:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1conok-0006mY-LH
	for bug-guix@gnu.org; Fri, 17 Mar 2017 05:05:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25917.B25917.148974144525999@debbugs.gnu.org>
In-Reply-To: <20170316174029.1663-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Thu, 16 Mar 2017 18:40:29 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 25917@debbugs.gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/system/linux-initrd.scm (base-initrd): Move helper-packages body to=
 ...
> * gnu/system/file-systems.scm (file-system-packages): ... here.
> Also export it.
> * gnu/services/base.scm (file-system-shepherd-service): Set PATH by using
> file-system-packages.

Exactly what we need!

Could you just make it two patches:

  1. introduce =E2=80=98file-system-packages=E2=80=99;
  2. Use it in =E2=80=98file-system-shepherd-service=E2=80=99.

> +(define (file-system-type-predicate type)
> +  (lambda (fs)
> +    (string=3D? (file-system-type fs) type)))
> +
> +(define* (file-system-packages file-systems #:key (volatile-root? #f))

Please add a docstring to these procedures.

You can also remove the now-unused =E2=80=98file-system-type-predicate=E2=
=80=99
procedure that is in =E2=80=98base-initrd=E2=80=99.

OK with these changes.

Thank you!

Ludo=E2=80=99.