From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#25988: [PATCH] bug#25988: python2-urwid tests fail
Date: Mon, 01 May 2017 16:47:17 +0200
Message-ID: <87efw83a8a.fsf@gnu.org>
References: <87innn8goq.fsf@gmail.com> <87o9vsh19x.fsf@gmail.com>
	<8737d4ks8l.fsf@gnu.org> <87o9veo0n7.fsf_-_@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53216)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d5CcP-00086A-Ta
	for bug-guix@gnu.org; Mon, 01 May 2017 10:48:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d5CcM-0003y2-Sc
	for bug-guix@gnu.org; Mon, 01 May 2017 10:48:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51543)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d5CcM-0003xu-OU
	for bug-guix@gnu.org; Mon, 01 May 2017 10:48:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d5CcM-0001az-Hb
	for bug-guix@gnu.org; Mon, 01 May 2017 10:48:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.25988.D25988.14936500516091.done@debbugs.gnu.org>
In-Reply-To: <87o9veo0n7.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Sun,
	30 Apr 2017 15:44:12 +0900")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 25988-done@debbugs.gnu.org

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
> [...]
>
>>
>> I=E2=80=99ve seen the failure once and it succeeded on a subsequent rebu=
ild, so
>> I came to the conclusion that this is a non-deterministic failure.  That
>> would explain why the problem doesn=E2=80=99t show up on Hydra.
>>
>> Does it fail systematically for you?
>>
>
> Yes, it does! I can re-run the `guix system reconfigure ...' as
> many times as I want and always get the same two failures. However, if I
> keep the failed derivation and run the tests manually, I've found that
> using 'strace' will cause more failures/errors; so it seems
> non-deterministic; maybe a racing issue?
>
> I've opened an issue on their GitHub tracker
> (https://github.com/urwid/urwid/issues/230). Interestingly the same
> tests run fine with Python 3, with or without using strace.
>
> I've attached a patch that disables the problematic vterm tests, only
> for the python2-urwid package.

Sounds reasonable to me.

> Maxim
>
> From 56e769bee4a47136e0eee251c87a58b8359a8611 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Sun, 30 Apr 2017 14:55:47 +0900
> Subject: [PATCH] gnu: Disable vterm tests for python2-urwid
>
> * gnu/packages/python.scm (python2-urwid)['delete-test_vterm]: Add phase =
to
> delete problematic test modules.

Applied, thanks!

Ludo=E2=80=99.