From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: bug#30434: magit =?UTF-8?Q?won=E2=80=99t?= work over TRAMP Date: Fri, 16 Feb 2018 14:00:50 -0500 Message-ID: <87eflklpy5.fsf@netris.org> References: <87lgfyl67x.fsf@elephly.net> <87mv0e2jvm.fsf@gmail.com> <876072koq0.fsf@elephly.net> <87wozgosxx.fsf@netris.org> <871shny0a1.fsf@gmail.com> <877erfph9m.fsf@netris.org> <87po56avqn.fsf@gmail.com> <873721mhbh.fsf@netris.org> <874lmg6fgb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emlGp-0003sb-2m for bug-guix@gnu.org; Fri, 16 Feb 2018 14:02:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emlGk-000184-82 for bug-guix@gnu.org; Fri, 16 Feb 2018 14:02:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:39302) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emlGk-00017x-4j for bug-guix@gnu.org; Fri, 16 Feb 2018 14:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1emlGj-00033R-OJ for bug-guix@gnu.org; Fri, 16 Feb 2018 14:02:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <874lmg6fgb.fsf@gmail.com> (Alex Kost's message of "Fri, 16 Feb 2018 19:56:36 +0300") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Alex Kost Cc: 30434@debbugs.gnu.org Hi Alex, Alex Kost writes: > Mark H Weaver (2018-02-16 04:09 -0500) wrote: > >> How does your own magit package avoid requiring git as an input? I'd be >> curious to see the diff between your package definition and ours. > > My version of magit is attached. Actually this problem (requiring git > during compilation) was introduced occasionally in Magit 2.11.0 and was > fixed soon after that, so "git" input will not be needed in the next > release. > > If you want more details, tarsius (the maintainer of Magit) added some > code to bring attention for his fundraising campaign: > > https://github.com/magit/magit/commit/bf71241122e1a0bf707913c87493214ceb12f588 Thanks for interesting details, and for your modified 'magit' package recipe. Having looked it over, I'm inclined to leave our 'magit' package as it is now. It's a very quick build, and also a leaf package (except for 'magit-svn'), so I don't see much practical benefit to removing 'git' as an input. Other opinions welcome :) Mark