From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#37732: mps-youtube propagates util-linux Date: Fri, 01 Nov 2019 15:41:30 +0100 Message-ID: <87eeyrbqw5.fsf@gnu.org> References: <875zks27rf.fsf@GlaDOS.home> <878spo3en3.fsf@devup.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:41404) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQY7p-00082q-NQ for bug-guix@gnu.org; Fri, 01 Nov 2019 10:42:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQY7o-0002z9-Hx for bug-guix@gnu.org; Fri, 01 Nov 2019 10:42:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQY7o-0002ym-EP for bug-guix@gnu.org; Fri, 01 Nov 2019 10:42:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQY7m-0004ux-1Z for bug-guix@gnu.org; Fri, 01 Nov 2019 10:42:04 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <878spo3en3.fsf@devup.no> (Marius Bakke's message of "Sun, 13 Oct 2019 16:26:40 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Marius Bakke Cc: 37732@debbugs.gnu.org, Diego Nicola Barbato Hi! Marius Bakke skribis: > Diego Nicola Barbato writes: > >> Hi Guix, >> >> An unfortunate chain of propagated-inputs causes 'util-linux' (mount, >> umount, etc.) to be installed alongside 'mps-youtube': 'mps-youtube' >> propagates 'python-pygobject', which propagates 'glib', which propagates >> 'util-linux'. It seems to have been introduced with commit 6c237a2, >> when 'util-linux' was moved to the propagated-inputs of 'glib'. Do we know why this commit moved =E2=80=98util-linux=E2=80=99 to propagated= -inputs? Presumably because of this line in =E2=80=98gio-2.0.pc=E2=80=99, right? Requires.private: gmodule-no-export-2.0, zlib, mount >=3D 2.23, libselinux If it=E2=80=99s =E2=80=9Cjust=E2=80=9D because of this, I=E2=80=99d say we = don=E2=80=99t need to propagate =E2=80=98util-linux=E2=80=99: we only build shared libraries for GLib anywa= y, so none of our packages actually use =E2=80=98Requires.private=E2=80=99. If we were t= o add packages requiring it, it=E2=80=99s fine to just add =E2=80=98mount=E2=80= =99 as an explicit inputs of these packages IMO. We could follow the same reasoning for the other things that are propagated due to their being listed in =E2=80=98Requires.private=E2=80=99. Thoughts? Moving =E2=80=98util-linux=E2=80=99 back to =E2=80=98inputs=E2=80=99 could = perhaps be done on the next =E2=80=98staging=E2=80=99 or on =E2=80=98core-updates=E2=80=99. > I have attached a WIP patch that fixes this "long term", by moving the > util-linux libraries to a separate output. It rebuilds 7753 packages > and is intended for the 'core-updates' branch. > > From b9cbe08694ddd8248ac32ce60d5fc40d5c619a54 Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Sun, 13 Oct 2019 16:07:44 +0200 > Subject: [PATCH] gnu: util-linux: Move libraries to separate output. > > Fixes . > Reported by Diego Nicola Barbato . > > * gnu/packages/linux.scm (util-linux)[outputs]: Add "dev". > [arguments]: Update #:configure-flags accordingly. Add phase > "adjust-bindirs", and rename "move-static-libraries" to "move-libraries", > while adding a substitution for the .pc files. > * gnu/packages/fontutils.scm (fontconfig)[propagated-inputs]: Use the "de= v" > output of UTIL-LINUX. > * gnu/packages/glib.scm (glib)[propagated-inputs]: Likewise. [...] > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -1089,19 +1089,40 @@ providing the system administrator with some help= in common tasks.") > (("build_kill=3Dyes") "build_kill=3Dno")) > #t)))) > (build-system gnu-build-system) > - (outputs '("out" > - "static")) ; >2 MiB of static .a libraries > + (outputs '("out" ;6.4 MiB executables and document= ation > + "dev" ;8.8 MiB shared libraries, header= s and locales > + "static")) ;2.9 MiB static .a libraries Shared libraries are not just for development, so I=E2=80=99d say it should= be =E2=80=9Clib=E2=80=9D instead, no? Thanks, Ludo=E2=80=99.