unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
To: romulasry <romulasry@protonmail.com>
Cc: 41794@debbugs.gnu.org
Subject: bug#41794: Thoughts on using Zstd compression instead of lzip
Date: Wed, 10 Jun 2020 22:59:44 +0200	[thread overview]
Message-ID: <87eeqmr60v.fsf@nckx> (raw)
In-Reply-To: <mQL02MBzUI0Or1OBC-6OI05eEgYrLxIalc2JKMZWQg6ysB93UfrP-rfzmFOKYvauVJ1lLmyGHVBz3drFUKRR6tSgTaaBP58Is7f0rX98UAE=@protonmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 350 bytes --]

Romulas,

It's not clear where you want to see zstd used.  Here's a trivial 
patch to add Zstd to ‘guix pack’, if that's what you mean.

I didn't submit it in the past because I dread bikeshedding the 
compression level.  -3 is the default, and compresses slightly 
better than gzip in a fraction of the time.

Kind regards,

T G-R


[-- Attachment #1.2: 0001-pack-Add-zstd-compressor.patch --]
[-- Type: text/x-patch, Size: 1221 bytes --]

From fa2ead6ac0f6c005e6392d6073122c7191e08944 Mon Sep 17 00:00:00 2001
From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Fri, 08 Nov 2019 09:03:27 +0100
Subject: [PATCH] pack: Add zstd compressor.

* guix/scripts/pack.scm (%compressors): Add ztsd.
---
 guix/scripts/pack.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index 518bf6e7e3..5e71ca9c21 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2018 Konrad Hinsen <konrad.hinsen@fastmail.net>
 ;;; Copyright © 2018 Chris Marusich <cmmarusich@gmail.com>
 ;;; Copyright © 2018 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -81,6 +82,8 @@
                     #~(#+(file-append xz "/bin/xz") "-e"))
         (compressor "bzip2" ".bz2"
                     #~(#+(file-append bzip2 "/bin/bzip2") "-9"))
+        (compressor "zstd" ".zst"
+                    #~(#+(file-append zstd "/bin/zstd") "-3"))
         (compressor "none" "" #f)))
 
 ;; This one is only for use in this module, so don't put it in %compressors.
-- 
2.26.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2020-06-10 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 19:22 bug#41794: Thoughts on using Zstd compression instead of lzip romulasry via Bug reports for GNU Guix
2020-06-10 20:59 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix [this message]
2020-06-11 21:21   ` Ludovic Courtès
2020-06-13 20:30   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeqmr60v.fsf@nckx \
    --to=bug-guix@gnu.org \
    --cc=41794@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=romulasry@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).