From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2EVKEG4W415gXQAA0tVLHw (envelope-from ) for ; Fri, 12 Jun 2020 05:45:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0G4PDG4W4151bQAAB5/wlQ (envelope-from ) for ; Fri, 12 Jun 2020 05:45:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9130F940656 for ; Fri, 12 Jun 2020 05:45:17 +0000 (UTC) Received: from localhost ([::1]:53008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjcV8-0001yp-UV for larch@yhetil.org; Fri, 12 Jun 2020 01:45:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjcUw-0001yc-Hh for bug-guix@gnu.org; Fri, 12 Jun 2020 01:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjcUw-0006AB-7q for bug-guix@gnu.org; Fri, 12 Jun 2020 01:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jjcUw-0006QC-67 for bug-guix@gnu.org; Fri, 12 Jun 2020 01:45:02 -0400 Subject: bug#41498: sed fails to build on kernels with selinux Resent-From: Chris Marusich Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Fri, 12 Jun 2020 05:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41498 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 41498-close@debbugs.gnu.org Mail-Followup-To: 41498@debbugs.gnu.org, cmmarusich@gmail.com, cmmarusich@gmail.com Received: via spool by 41498-done@debbugs.gnu.org id=D41498.159194064224556 (code D ref 41498); Fri, 12 Jun 2020 05:45:01 +0000 Received: (at 41498-close) by debbugs.gnu.org; 12 Jun 2020 05:44:02 +0000 Received: from localhost ([127.0.0.1]:38707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjcTu-0006NX-6f for submit@debbugs.gnu.org; Fri, 12 Jun 2020 01:44:02 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:34714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjcTs-0006NE-3o for 41498-close@debbugs.gnu.org; Fri, 12 Jun 2020 01:43:57 -0400 Received: by mail-pj1-f67.google.com with SMTP id a45so3876254pje.1 for <41498-close@debbugs.gnu.org>; Thu, 11 Jun 2020 22:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=DvUtHv+HpXM2FySWQ9xMK7PBw9ZoQOW4xEcs7sP4bUc=; b=AR3FDGHFWGCaOPRYXZx7xLdYIW7xqAkB7kCELbitsj5ZCSTzcsVdDxe1hd0sDDp+kZ GXcMoQN9GT3ScyUox+QdpnMD662W5PWK9m9BVXNH0o/1G1LtSn0JnejYPGhv5eAeNWdC 4j2GnAjKH1T6XgZ9xYieqNBYTg0PPbSsRSwFrs4Itk9wPWfnx8YMBqqiDhh5U2pG0Ety 10QRx+iFrkRxzkwum4hXA8QiB/IRFUTT7E4VADLqwvziyv5gEjesbiDa5nkFHHCIVEDy wz8Btbykh5Iwp7jMg1HFYZODfop4vTPSlphkWc1IZkZ6IRv7QEEuU5H1MmGV4rhbU1tq 2Tlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=DvUtHv+HpXM2FySWQ9xMK7PBw9ZoQOW4xEcs7sP4bUc=; b=aiBo89+kRwMUqWATRYKbWpglXQTtfWcQB+q0AubkaBTSRPhup4NeGeVmUZi2U5rHq8 FV1DnNYS+EaYu6o6b3PeDI/DITidOXq5Q3POWWEtTDkMkqo4uPj+ZNoUGy0Aq4oi+eab 9Za2+8q1222XIqgIIJ80icXVxhpgiRfPzdDPCRfGQIGK9/sRtJ5Tnju6m2AmY6XhtC0s aJk75Xvz82acxd/g1JdaeV5YpvRzl2+ucWCmTiuDySsUT06GT/owDQCqzqsoftHEBkdT aF6d3/etk+gqho0ZOkT47kb6eTffrer0NRfm7+FgY3jc/4k1jBICnWB725FlK3w4ZCru CFyw== X-Gm-Message-State: AOAM531oZlBsCV9f/8Fe8M4SR0bChpfjVwKVSd+6zV61L4BDr6tTDBYM /Qu4uwWhHbo8TTePaQCmMeo= X-Google-Smtp-Source: ABdhPJxQhr3fxSqUxuQvEFuopSjC+JNVcYwCDBwpoC0nDuw5S+wBNzW4PjS13o5CMKN1kqfF7zNzfg== X-Received: by 2002:a17:90a:206c:: with SMTP id n99mr11898194pjc.160.1591940629951; Thu, 11 Jun 2020 22:43:49 -0700 (PDT) Received: from garuda-lan (c-73-97-103-127.hsd1.wa.comcast.net. [73.97.103.127]) by smtp.gmail.com with ESMTPSA id x2sm4849141pfj.142.2020.06.11.22.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 22:43:48 -0700 (PDT) From: Chris Marusich In-Reply-To: <87ftb3crzy.fsf@gmail.com> (Chris Marusich's message of "Wed, 10 Jun 2020 00:14:09 -0700") References: <87zh9xrbpj.fsf@gmail.com> <87blm5yhgx.fsf@gmail.com> <87ftb3crzy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Thu, 11 Jun 2020 22:43:43 -0700 Message-ID: <87eeqkltyo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=AR3FDGHF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: G8IS5pu54XzH --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, With the attached patch, sed builds on my Fedora machine. Yay! There was a small mistake in my prior email to this bug report, so you can ignore that patch. Chris Marusich writes: > diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm > index 279fe9e3d8..f075ee8f74 100644 > --- a/gnu/packages/base.scm > +++ b/gnu/packages/base.scm > @@ -15,6 +15,7 @@ > ;;; Copyright =C2=A9 2018 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2018, 2019 Ricardo Wurmus > ;;; Copyright =C2=A9 2020 Vitaliy Shatrov > +;;; Copyright =C2=A9 2020 Chris Marusich > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -141,7 +142,21 @@ including, for example, recursive directory searchin= g.") > ".tar.gz")) > (sha256 > (base32 > - "0alqagh0nliymz23kfjg6g9w3cr086k0sfni56gi8fhzqwa3xksk")))) > + "0alqagh0nliymz23kfjg6g9w3cr086k0sfni56gi8fhzqwa3xksk")) > + ;; Remove this patch once upstream releases a fixed version. > + (patches > + (list > + (origin > + (method url-fetch) > + (uri (string-append > + "https://debbugs.gnu.org/cgi/bugreport.cgi?" > + "att=3D1;msg=3D16;bug=3D36150;filename=3D0001-test= s-" > + "Export-CONFIG_HEADER-to-test-scripts.patch")) > + (file-name > + "sed-Export-CONFIG_HEADER-to-test-scripts.patch") > + (sha256 > + (base32 > + "0q78qzc0mv4bmsf7wnqj9fjbrwb71xz18v07h0jz2cwnbbj1nwm9"= ))))))) > (build-system gnu-build-system) > (synopsis "Stream editor") > (native-inputs > --=20 > 2.26.2 Even though this patch is appropriate for the sed maintainers, it is not appropriate for use in Guix's sed package definition. This is because the patch changes testsuite/local.mk, which is used only when creating the release distribution of sed (via an include directive in Makefile.am), and Guix builds sed from a release distribution tarball. As a result, even if Guix modifies the file, it does not have the desired effect, and the test still fails for the same reason as before. One way to work around this is to modify the Makefile.in, which is generated by Automake and included in the release distribution. I have gone ahead and committed the sed patch to core-updates in a48a3f0640d76cb5e5945557c9aae6dabce39d93. I have committed the guix lint improvement to master in 21887021b9acf60157b1b0a39c16f2ec6498021b. I am closing this bug report. =2D-=20 Chris --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-sed-Make-it-build-on-SELinux-enabled-kernels.patch Content-Transfer-Encoding: quoted-printable From=2024edab1ef4ecedd2d9971a96a516d800d6933201 Mon Sep 17 00:00:00 2001 From: Chris Marusich Date: Tue, 9 Jun 2020 23:35:56 -0700 Subject: [PATCH] gnu: sed: Make it build on SELinux-enabled kernels. Fixes: . * gnu/packages/base.scm (sed)[origin][snippet]: New field. This adds a snippet, equivalent to the patch submitted upstream, which fixes an issue that prevents sed from building on SELinux-enabled kernels. =2D-- gnu/packages/base.scm | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index 279fe9e3d8..2c7b4e6882 100644 =2D-- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -15,6 +15,7 @@ ;;; Copyright =C2=A9 2018 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2018, 2019 Ricardo Wurmus ;;; Copyright =C2=A9 2020 Vitaliy Shatrov +;;; Copyright =C2=A9 2020 Chris Marusich ;;; ;;; This file is part of GNU Guix. ;;; @@ -141,7 +142,19 @@ including, for example, recursive directory searching.= ") ".tar.gz")) (sha256 (base32 =2D "0alqagh0nliymz23kfjg6g9w3cr086k0sfni56gi8fhzqwa3xksk")))) + "0alqagh0nliymz23kfjg6g9w3cr086k0sfni56gi8fhzqwa3xksk")) + ;; Remove this snippet once upstream releases a fixed version. + ;; This snippet changes Makefile.in, even though the upstream + ;; patch changes testsuite/local.mk, since we build sed from a + ;; release tarball. See: https://bugs.gnu.org/36150 + (snippet + '(begin + (substitute* "Makefile.in" + (("^ abs_srcdir=3D'\\$\\(abs_srcdir\\)'.*" previous-lin= e) + (string-append + previous-line + " CONFIG_HEADER=3D'$(CONFIG_HEADER)'\t\t\\\n"))))) + (modules '((guix build utils))))) (build-system gnu-build-system) (synopsis "Stream editor") (native-inputs =2D-=20 2.26.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAl7jFg8ACgkQ3UCaFdgi Rp2fpg//ZxUC4SukDteuQJO98TqoYVoI6y8SoOV0y2Wkukwy2aCExZOMHGouJfJ2 hwap65JT0GGpZs/tWx4gHmhwTHi0reQlPEoTyIvtNhyTCB2gyml1KIa2vwkSozsv 7WJ+HxjQoPqfhtuLQvHlWBmdOo1VNGFvSGTXebyGNsIVSCnPQe471/4pID40LySv lECIKaZ8Qqcd++sVhJrTwFO2pVVH3gb9FgtV8J5FI3CSIVgpoYXdfqG9odwfIbMW NTZez5fp3DSCcKsoigu2vbAZVADUoWa1AAslAqAq4woRPmn3hiIAiCpHpeRAJafU 0kT+7dlX3x2eUkABYrKawXxj1oUfmCDc/Sq3Kup7Q1tZgU/GuVccMuC3xkhSEAMq 9zU6PK0/Eh/ZbCL8w8FmGNJeTSLBkGgwDBizbWsKmxtS0c3N/HpVnHRhd98xhuw5 K4bpKsvmnvxxmptUPWDAzNZnzsP1GC0Y015vS5asDZfKfMASa1L2roTls9e85yfW VJIKWkr4Vhv856/cg9iPffeed0RyVhFVziS4RUL4UlNN0EYfjqmc6OgRzHsY2vQJ KTBTCl63VEPBwga/53ZrT7H4bg8pkigRy8RqDh+34NRJhoPiF3n3qvnb/+DX4UrW h8YV+0OaVBk0zE9M3GK5y3GQPErs1opQEV1UPvQLopxnEjH0Bv0= =7hop -----END PGP SIGNATURE----- --==-=-=--