From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WPDeHh05yV9/DQAA0tVLHw (envelope-from ) for ; Thu, 03 Dec 2020 19:14:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AD6nGh05yV9sGwAAB5/wlQ (envelope-from ) for ; Thu, 03 Dec 2020 19:14:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 06FFD9402DD for ; Thu, 3 Dec 2020 19:14:36 +0000 (UTC) Received: from localhost ([::1]:44376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kku3m-0004jR-CU for larch@yhetil.org; Thu, 03 Dec 2020 14:14:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kku3G-0004hq-3W for bug-guix@gnu.org; Thu, 03 Dec 2020 14:14:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kku3F-0006t3-SH for bug-guix@gnu.org; Thu, 03 Dec 2020 14:14:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kku3F-0003vq-Ma for bug-guix@gnu.org; Thu, 03 Dec 2020 14:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44491: Support GUIX_DISABLE_NETWORK_TESTS environment variable Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 03 Dec 2020 19:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44491 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44491-submit@debbugs.gnu.org id=B44491.160702282115077 (code B ref 44491); Thu, 03 Dec 2020 19:14:01 +0000 Received: (at 44491) by debbugs.gnu.org; 3 Dec 2020 19:13:41 +0000 Received: from localhost ([127.0.0.1]:41806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kku2u-0003v6-VD for submit@debbugs.gnu.org; Thu, 03 Dec 2020 14:13:41 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:42974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kku2s-0003ut-NL for 44491@debbugs.gnu.org; Thu, 03 Dec 2020 14:13:39 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id C95F01AA41; Thu, 3 Dec 2020 11:13:32 -0800 (PST) From: Vagrant Cascadian In-Reply-To: <87sg8mbyuz.fsf@gnu.org> References: <87k0uy6um8.fsf@yucca> <87y2jbu4gx.fsf@gnu.org> <87k0utt6zt.fsf@yucca> <87wnysnbs6.fsf@gnu.org> <87h7pwtvde.fsf@yucca> <87eel0tok1.fsf@yucca> <87sg8mbyuz.fsf@gnu.org> Date: Thu, 03 Dec 2020 11:13:04 -0800 Message-ID: <87eek6n1of.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44491@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.88 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 06FFD9402DD X-Spam-Score: -3.88 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: AdOz6hVJ3sXj --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2020-12-03, Ludovic Court=C3=A8s wrote: > Should we close this issue now that you found the RES_OPTIONS=3Dattempts:0 > trick, or do you think we should still keep the refactoring bits? Well, it's three cases of copy-paste code, and one nearly identical but inverted. Someone once suggested to me to refactor on the third instance of copy-pasted code... Having common tests makes it a little easier to add to new tests in the future with the same code, and if there's ever a change in the underlying code, you fix it in once place. It also opens the door to adding other common functions, if it comes up. So I'd say it's worth applying, though also would be ok with leaving as is and just taking advantage of the RES_OPTIONS=3Dattempts:0 workaround. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX8k4wAAKCRDcUY/If5cW qqyoAP47YVr/AamAG4687PKQIaSEnn/rn//ONsppKM57SIrwzAD9HhRLLExmFU+R 5NoEUcWG5qCgMV+diEkgeKTE4p4LWwg= =a8VK -----END PGP SIGNATURE----- --=-=-=--