From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2KT6MuCSAGBOAgAA0tVLHw (envelope-from ) for ; Thu, 14 Jan 2021 18:52:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MA6JLuCSAGDZVwAAbx9fmQ (envelope-from ) for ; Thu, 14 Jan 2021 18:52:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42A90940355 for ; Thu, 14 Jan 2021 18:52:16 +0000 (UTC) Received: from localhost ([::1]:48384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l07jC-0006AH-2k for larch@yhetil.org; Thu, 14 Jan 2021 13:52:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l06ye-0007gK-4O for bug-guix@gnu.org; Thu, 14 Jan 2021 13:04:10 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l06yY-0003zL-Jp for bug-guix@gnu.org; Thu, 14 Jan 2021 13:04:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l06yY-0008L1-EE for bug-guix@gnu.org; Thu, 14 Jan 2021 13:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45867: hurd-vm: custom disk-size ignored Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 14 Jan 2021 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45867 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 45867@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161064741832019 (code B ref -1); Thu, 14 Jan 2021 18:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jan 2021 18:03:38 +0000 Received: from localhost ([127.0.0.1]:39130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l06y9-0008KM-T9 for submit@debbugs.gnu.org; Thu, 14 Jan 2021 13:03:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:44678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l06y5-0008KB-E4 for submit@debbugs.gnu.org; Thu, 14 Jan 2021 13:03:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l06y5-00079T-7R for bug-guix@gnu.org; Thu, 14 Jan 2021 13:03:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55490) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l06y5-0003rL-01; Thu, 14 Jan 2021 13:03:33 -0500 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=56648 helo=dundal.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l06y3-0007v7-OQ; Thu, 14 Jan 2021 13:03:32 -0500 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl X-Url: http://AvatarAcademy.nl Date: Thu, 14 Jan 2021 19:03:28 +0100 Message-ID: <87eeinqtu7.fsf@verum.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 42A90940355 X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: e/TXpXYECXAq On current master, setting a bigger disk-size for a childhurd --8<---------------cut here---------------start------------->8--- (service hurd-vm-service-type (hurd-vm-configuration (disk-size (* 12 (expt 2 30))) ;12GiB --8<---------------cut here---------------end--------------->8--- is being ignored. I am suspecting > commit 859b362f81598830d7ff276b96a8724aee3c4db7 > Author: Ludovic Court=C3=A8s > AuthorDate: Mon Dec 7 12:38:25 2020 +0100 > > services: hurd-vm: Avoid circular dependency with (gnu system images = hurd). >=20=20=20=20=20 > * gnu/services/virtualization.scm (hurd-vm-disk-image): Use > 'lookup-image-type-by-name' instead of referring to 'hurd-disk-image' > from (gnu system images hurd). > --- > gnu/services/virtualization.scm | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualizatio= n.scm > index eaf0bbd..f435630 100644 > --- a/gnu/services/virtualization.scm > +++ b/gnu/services/virtualization.scm [..] > @@ -913,14 +912,12 @@ that will be listening to receive secret keys on po= rt 1004, TCP." > (define (hurd-vm-disk-image config) > "Return a disk-image for the Hurd according to CONFIG. The secret-ser= vice > is added to the OS specified in CONFIG." > - (let ((os (secret-service-operating-system (hurd-vm-configuration-os c= onfig))) > - (disk-size (hurd-vm-configuration-disk-size config))) > - (system-image > - (image > - (inherit hurd-disk-image) > - (format 'compressed-qcow2) > - (size disk-size) > - (operating-system os))))) This system-image included (size disk-size), and here > + (let* ((os (secret-service-operating-system > + (hurd-vm-configuration-os config))) > + (disk-size (hurd-vm-configuration-disk-size config)) > + (type (lookup-image-type-by-name 'hurd-qcow2)) > + (os->image (image-type-constructor type))) > + (system-image (os->image os)))) disk-size goes unused. So we probably need something like diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.= scm index f435630faf..3ede822183 100644 --- a/gnu/services/virtualization.scm +++ b/gnu/services/virtualization.scm @@ -917,7 +917,9 @@ is added to the OS specified in CONFIG." (disk-size (hurd-vm-configuration-disk-size config)) (type (lookup-image-type-by-name 'hurd-qcow2)) (os->image (image-type-constructor type))) - (system-image (os->image os)))) + (system-image + (image (inherit (os->image os)) + (size disk-size))))) =20 (define (hurd-vm-port config base) "Return the forwarded vm port for this childhurd config." Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com