From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eHAROPV5hWCbtQAAgWs5BA (envelope-from ) for ; Sun, 25 Apr 2021 16:17:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0D25M/V5hWDjUgAAB5/wlQ (envelope-from ) for ; Sun, 25 Apr 2021 14:17:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4389C1F87E for ; Sun, 25 Apr 2021 16:17:25 +0200 (CEST) Received: from localhost ([::1]:34252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lafZb-00016y-Br for larch@yhetil.org; Sun, 25 Apr 2021 10:17:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lafZG-00016n-7z for bug-guix@gnu.org; Sun, 25 Apr 2021 10:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60057) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lafZG-0002cx-0o for bug-guix@gnu.org; Sun, 25 Apr 2021 10:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lafZF-00040C-Rh for bug-guix@gnu.org; Sun, 25 Apr 2021 10:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47889: [installer image] grub-install efi fails getting canonical path to /boot/efi on dos-formatted disk Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 25 Apr 2021 14:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47889 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 47889-submit@debbugs.gnu.org id=B47889.161936016615317 (code B ref 47889); Sun, 25 Apr 2021 14:17:01 +0000 Received: (at 47889) by debbugs.gnu.org; 25 Apr 2021 14:16:06 +0000 Received: from localhost ([127.0.0.1]:43369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lafYM-0003yy-4S for submit@debbugs.gnu.org; Sun, 25 Apr 2021 10:16:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lafYK-0003yG-IL for 47889@debbugs.gnu.org; Sun, 25 Apr 2021 10:16:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36867) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lafYE-0001ya-Jn; Sun, 25 Apr 2021 10:15:58 -0400 Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=56634 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lafYE-0005ve-6U; Sun, 25 Apr 2021 10:15:58 -0400 From: Mathieu Othacehe References: <20210419092928.p426llfdlvb5ay3z@pelzflorian.localdomain> <878s5a1m9k.fsf@gnu.org> <20210422143651.fwdrrqmcw225eh23@pelzflorian.localdomain> <87im4ds2su.fsf@gnu.org> Date: Sun, 25 Apr 2021 16:15:56 +0200 In-Reply-To: <87im4ds2su.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 23 Apr 2021 12:39:13 +0200") Message-ID: <87eeeyv49v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47889@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619360245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=B2pfaSPcUtpyRN+TKLs7pbDCmqXHBBFgLBRqZzd6WTw=; b=o4w33Vfue8NvbLoz+TnYgZI2Oq5Z54r7EhQGoig048T5eNIT+id2JPI+4YkR+pn+V9epc2 Gb6vzWp17cDbmD56Ut+xE+Dj8HwcNo5PK4Zb6Hase1stFWXkPd9T0tK3VQqKpFMJhYPQ32 NneV02LiK3iroO63vBozMLPIirvQAOv5mZ3MCGy0OPm5YkOH+pCzooeCHf5IgKgzjR3TEC vwrs3a+SFnfE0jQmG3Sczp7sazmTD3V//d1duuDUqU/U5qZR0YiiTrcm5A1jTdqmOt8DVI 5mV3TLyQE4sZB4tgE9ykTIq+zrpxqFRnMVSzaC/9e3uMdEC8Jv1qJaFseLCYjA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619360245; a=rsa-sha256; cv=none; b=Ma2aHFPyZd/EcmkZ3TEIA99939C3flPJlDBsScA4pA30ZkteKNsOh+Fl55QW81W+QHZXw4 cS1dHCowKe6EHRT4Bz+u73Dzce2nti3cX1LBekyy3j1y0uu54j+xyI04kWx77el/BccCY2 491QP39pqY0tPMjyTGtxNeykJVylw2mfKY5vxs4lfCpWIBagke7jrMN2dXYcC0or+8vwOQ SBTvGeNVrQwthVNbd59vsLaYbEWfESlgLfSXBx1WG1JDiLjpxGw4sl8cvFxV/9mgb4CCFK EExVXFvTKSZ1ZCbInLFZSNc2aP4Dl6z6r+g+9xScCqOaz/8hVKVoFkS7FnKT6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 4389C1F87E X-Spam-Score: -2.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0H1/dKlVGJDF Hello, > I=E2=80=99m not entirely sure how it decides between GPT and DOS, though; > Mathieu? > > We should add UEFI installation tests using OVMF. I could reproduce this issue with the following steps: --8<---------------cut here---------------start------------->8--- qemu-img create -f qcow2 guix-system.img 50G qemu-system-x86_64 -m 1024 -bios $(guix build ovmf)/share/firmware/ovmf_x64= .bin -cdrom /gnu/store/ -hda guix-system.img Choose the msdos disk type in the auto-partitioning installer partitioning = menu. --8<---------------cut here---------------end--------------->8--- When using the auto-partitioning, the installer probes the selected installation device type. If it has no type, like with my reproducer, it asks whether to use msdos or gpt. If the disk is already using an msdos or gpt layout, it is preserved. Then, the auto-partitioning considers erroneously that ESP partitions are not supported on msdos disks with the following code snippet: --8<---------------cut here---------------start------------->8--- (and (not has-extended?) ;not msdos? (if (efi-installation?) (and (not esp-partition) (user-partition (fs-type 'fat32) (esp? #t) (size new-esp-size) (mount-point (default-esp-mount-point)))) (user-partition (fs-type 'ext4) (bootable? #t) (bios-grub? #t) (size bios-grub-size)))) --8<---------------cut here---------------end--------------->8--- Finally, grub-efi fails because there's no /boot/efi mount point. This problem can then occur for two reasons: 1. The user is booting the installation image with UEFI support, using an empty installation device, choosing auto-partition and msdos as disk type. 2. The user is booting the installation image with UEFI support, using an already msdos formatted installation device and choosing auto-partition. I think we could solve 1. easily, by forcing the GPT layout. Solving 2. is a bit trickier. As Ludo suggested, we also need to create new installer tests covering UEFI installations. I'll try to come up with a patch soon. Thanks, Mathieu =20=20