From: Pierre Neidhardt <mail@ambrevar.xyz>
To: 56334@debbugs.gnu.org
Cc: glv@posteo.net
Subject: bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system?
Date: Fri, 01 Jul 2022 12:16:53 +0200 [thread overview]
Message-ID: <87edz5jfxm.fsf@ambrevar.xyz> (raw)
[-- Attachment #1: Type: text/plain, Size: 3048 bytes --]
While trying to package
https://github.com/s-expressionists/Cleavir
I hit a strange issue in which it would fail to compile, while calling
`asdf:load-system' locally worked.
Then I realized that our asdf-build-system/sbcl uses
`asdf:compile-system' instead of `asdf:load-system'.
From the ASDF doc:
--8<---------------cut here---------------start------------->8---
This will make sure all the files in the system are compiled, but not
necessarily load any of them in the current image; on most systems, it
will _not_ load all compiled files in the current image. This function
exists for symmetry with 'load-system' but is not recommended unless you
are writing build scripts and know what you're doing.
--8<---------------cut here---------------end--------------->8---
So should we really use it?
By the way this _may_ be related to the issue we've got with loading the
tests of some packages, like sbcl-jonathan:
--8<---------------cut here---------------start------------->8---
;; Tests fail with: Component JONATHAN-ASD::JONATHAN-TEST not found,
;; required by #<SYSTEM "jonathan">. Why?
--8<---------------cut here---------------end--------------->8---
Recipe to reproduce:
- git clone https://github.com/s-expressionists/Cleavir
- cd Cleavir
- guix shell sbcl sbcl-acclimation sbcl-concrete-syntax-tree sbcl-closer-mop -- sbcl
- (asdf:initialize-source-registry `(:source-registry (:tree ,(uiop:getcwd)) :inherit-configuration))
- (asdf:compile-system :cleavir-abstract-interpreter)
--8<---------------cut here---------------start------------->8---
debugger invoked on a SB-PCL:CLASS-NOT-FOUND-ERROR in thread
#<THREAD "main thread" RUNNING {100B598173}>:
There is no class named CLEAVIR-ABSTRACT-INTERPRETER:STRATEGY.
Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.
restarts (invokable by number or by possibly-abbreviated name):
0: [TRY-RECOMPILING ] Recompile control and try loading it again
1: [RETRY ] Retry
loading FASL for #<CL-SOURCE-FILE "cleavir-abstract-interpreter" "control">.
2: [ACCEPT ] Continue, treating
loading FASL for #<CL-SOURCE-FILE "cleavir-abstract-interpreter" "control">
as having been successful.
3: Retry ASDF operation.
4: [CLEAR-CONFIGURATION-AND-RETRY] Retry ASDF operation after resetting the
configuration.
5: Retry ASDF operation.
6: Retry ASDF operation after resetting the
configuration.
7: [ABORT ] Exit debugger, returning to top level.
--8<---------------cut here---------------end--------------->8---
And then
- (asdf:load-system :cleavir-abstract-interpreter)
works like a charm!
Thoughts?
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next reply other threads:[~2022-07-01 10:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 10:16 Pierre Neidhardt [this message]
2022-07-01 11:13 ` bug#56334: Should asdf-build-system/sbcl use load-system instead of compile-system? Guillaume Le Vaillant
2022-07-01 11:45 ` Pierre Neidhardt
2022-07-01 12:22 ` Guillaume Le Vaillant
2022-07-01 14:46 ` Pierre Neidhardt
2022-07-01 16:40 ` Guillaume Le Vaillant
2022-07-01 17:07 ` Pierre Neidhardt
2022-07-02 10:17 ` Pierre Neidhardt
2022-07-03 10:19 ` Guillaume Le Vaillant
2022-07-04 15:18 ` Pierre Neidhardt
2022-07-04 19:57 ` Pierre Neidhardt
2022-07-05 8:56 ` Pierre Neidhardt
2022-07-17 16:19 ` Pierre Neidhardt
2022-08-03 14:49 ` Guillaume Le Vaillant
2022-08-04 14:01 ` Pierre Neidhardt
2022-07-01 14:30 ` Liliana Marie Prikler
2022-07-01 14:43 ` Pierre Neidhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edz5jfxm.fsf@ambrevar.xyz \
--to=mail@ambrevar.xyz \
--cc=56334@debbugs.gnu.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).