From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2IXaEvc4RmMprwAAbAwnHQ (envelope-from ) for ; Wed, 12 Oct 2022 05:48:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gBznEvc4RmPGXQAAauVa8A (envelope-from ) for ; Wed, 12 Oct 2022 05:48:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E47EF3B86C for ; Wed, 12 Oct 2022 05:48:06 +0200 (CEST) Received: from localhost ([::1]:46054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiSiz-00040e-GZ for larch@yhetil.org; Tue, 11 Oct 2022 23:48:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiSiw-00040W-OC for bug-guix@gnu.org; Tue, 11 Oct 2022 23:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiSiw-0005US-Gi for bug-guix@gnu.org; Tue, 11 Oct 2022 23:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiSiw-0000jq-9q for bug-guix@gnu.org; Tue, 11 Oct 2022 23:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#57790: Strange behavior with emacs-build-system Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 12 Oct 2022 03:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57790 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun , 57790@debbugs.gnu.org Received: via spool by 57790-submit@debbugs.gnu.org id=B57790.16655464252686 (code B ref 57790); Wed, 12 Oct 2022 03:48:02 +0000 Received: (at 57790) by debbugs.gnu.org; 12 Oct 2022 03:47:05 +0000 Received: from localhost ([127.0.0.1]:55290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiSi0-0000hG-NG for submit@debbugs.gnu.org; Tue, 11 Oct 2022 23:47:05 -0400 Received: from mout02.posteo.de ([185.67.36.66]:44665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiShx-0000gi-Sm for 57790@debbugs.gnu.org; Tue, 11 Oct 2022 23:47:03 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BD98E240101 for <57790@debbugs.gnu.org>; Wed, 12 Oct 2022 05:46:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665546415; bh=GValoljYw89lC57NbuSsds2n9SevIihJXsmSge7PVYM=; h=From:To:Subject:Date:From; b=HLhNQ5HMj65is0361K3n/SozXpQmNvc3wIE38KQdtYJ7FmxnyEq/RrwRxWuukXGq/ iwxtHOms3g1zUiZqBUKK701DUeGtifCdeCyxTux8N3k+559ALboaezEghMvxv+muq0 3/hhpnop8ktMkAImNrTOsiIie05V/5kQuzHfcQhCkAvqOViJbLUgh6vqzi7gr1nt0K rl0GfEYiYy1UML3KeZz4DyuHoZXC4V0Q7P/wgJkHkjiLyUkVzulXox5hNXwchQ3NmS HqFh8zR66oDSsQlhcaocjPTOHqWtqTdw967E4/oUIcl5SADHEPAEYYZYdGmpHmMbdG XS4EOhIOwO2tA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MnJVg4FKFz6tpW; Wed, 12 Oct 2022 05:46:51 +0200 (CEST) From: Fredrik Salomonsson In-Reply-To: <87k056qnag.fsf@d2.com> References: <87v8pqbr0o.fsf@d2.com> <86wn96ofhp.fsf@gmail.com> <87k056qnag.fsf@d2.com> Date: Wed, 12 Oct 2022 03:46:49 +0000 Message-ID: <87edvdzot2.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665546487; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RDGrO3gUZuezTWNr6ibnuDF0dRX73/fAocU/6EYEPIw=; b=DV5jSLk2qP5suR/l7VukNzeV/sxjm0AXWN8F8pmsBJThGRCmOhEDbHz8ATqIanaC71nyH9 lJA8bZzDcoP6z2WvnH4gFDovCG8VsXkftPUR9/bS9bY5lCgrgWlWwXR6qI0kJ67QZYWc+y iHcYKtymqglBMLo79AOAQYr3CA1m4wQK2WQQxden0F1uH3s/grtb97tG6mReK+M5jimWvt ZIXIyfuf6hHykFhGQCUP2xug6oBEbKgD3aL+tarn+PcP+CBRekq6wMkgEDdHonY5698bR4 opS086WclI/J/Api9EcKk4JZ/8QzWlypPs1nQ45Z6JEeS+El3WnMCxYZh31how== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665546487; a=rsa-sha256; cv=none; b=gThC/iS9UwxLVoJsDQGmDP2hXByRZvLjVV09sxsynllNL5KPhox/zAwrYNGu3Y/yApJLXd GJkiR7EZLh5R/YtLk8PY7QxrmPpnqk3s9AP4mAatnp/em1nimtHjVKIw7ElyGyTddN/Of1 D7zmCeyfEV5afdN0fgt4gBePDIUNlu/PzllxbkZFFN2KmV86n3CxF/oXSSyg37Km5QVn0P PczQ9Sinhjht2ID6UYvtNKTkBY9eOzflABELw+VzxQAcimXVQOeMKmqxDaJfmJdStBc6Ce 5ownm2n4n+B0BmPMOscasPr9CtmXgf1UIS878YGbfdxMsZuxXv2Dmo4nH2Fi/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=HLhNQ5HM; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=HLhNQ5HM; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E47EF3B86C X-Spam-Score: 6.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: pJ9+m/PAOtv7 Fredrik Salomonsson writes: > Hi, > > zimoun writes: > >> On Wed, 14 Sep 2022 at 02:59, Fredrik Salomonsson = wrote: >> >>> If I name the local clone `issue.el` (name of the directory); >>> `guix=C2=A0build=C2=A0-f=C2=A0guix.scm` will fail. It will just copy th= e file >>> `issue.el` and then `ert-runner` fails as there is no test directory. >>> >>> But if I name the local clone something else, e.g. `issue-el` then it >>> will copy all the files, `ert-runner` will be happy and >>> `guix=C2=A0build=C2=A0-f=C2=A0guix.scm` will succeed. >>> >>> I'm not sure if this is an issue in `emacs-build-system`, `local-file` >>> or plain old user error. >> >> Well, I guess it comes from =E2=80=99unpack=E2=80=99; which reads: >> >> --8<---------------cut here---------------start------------->8--- >> (define* (unpack #:key source #:allow-other-keys) >> "Unpack SOURCE into the build directory. SOURCE may be a compressed >> archive, a directory, or an Emacs Lisp file." >> (if (string-suffix? ".el" source) >> (begin >> (mkdir "source") >> (chdir "source") >> (copy-file source (store-file->elisp-source-file source)) >> #t) >> (gnu:unpack #:source source))) >> --8<---------------cut here---------------end--------------->8--- > > Ah, yeah that would make sense. > >> Well, I guess again that the =E2=80=99source=E2=80=99 should contain som= ething like, >> >> (file-name (git-file-name name version) >> >> to avoid the issue. But the naive approach does not work with >> =E2=80=99local-file=E2=80=99. > > Would `file-is-directory?` work? E.g. > > (if (and (string-suffix? ".el" source) > (not (file-is-directory? source))) > =E2=80=A6) > > I'm currently at work so I cannot test this right now. I just tested it and it at least fixed my issue. I haven't tested any other emacs package yet. Also I'm not sure if this is the best solution. But we now know it is the `unpack` phase that is the cause. --=20 s/Fred[re]+i[ck]+/Fredrik/g