From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AKiWDAZIYmOWSgEAbAwnHQ (envelope-from ) for ; Wed, 02 Nov 2022 11:35:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aGltDAZIYmOKuAAAauVa8A (envelope-from ) for ; Wed, 02 Nov 2022 11:35:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A953A11269 for ; Wed, 2 Nov 2022 11:35:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqB5L-000530-Vk; Wed, 02 Nov 2022 06:35:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqB5K-00050B-Gm for bug-guix@gnu.org; Wed, 02 Nov 2022 06:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqB5K-00068E-8d for bug-guix@gnu.org; Wed, 02 Nov 2022 06:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqB5K-00061N-4L for bug-guix@gnu.org; Wed, 02 Nov 2022 06:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58733: installer: coredump generation Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 02 Nov 2022 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58733 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 58733@debbugs.gnu.org Received: via spool by 58733-submit@debbugs.gnu.org id=B58733.166738527423098 (code B ref 58733); Wed, 02 Nov 2022 10:35:02 +0000 Received: (at 58733) by debbugs.gnu.org; 2 Nov 2022 10:34:34 +0000 Received: from localhost ([127.0.0.1]:44984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqB4r-00060T-Lu for submit@debbugs.gnu.org; Wed, 02 Nov 2022 06:34:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqB4q-00060F-Aq for 58733@debbugs.gnu.org; Wed, 02 Nov 2022 06:34:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqB4k-0005jK-VS for 58733@debbugs.gnu.org; Wed, 02 Nov 2022 06:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=d6OmjLlbEm3tZ3vkv+xcCGP0Li5+BvXg6nqBcEhxLxA=; b=l0ZmtrHHEHLWdh81KDbs BR/5jYDaOoYyeCwBsSUyHeVcF10Vq4KdrO/FcAwwiH95+YeSNKT2nU6xOcZUgnbisoQmDuHVtT07U vA76sx82F/FXQiASdWrgXqFv8LI9zF09HGCm2tECQ/NzCCWhiYhdcrVgVqpKvspjFZXQaIlys9I17 u8xjD74FLpY7tNo9GRxITICbt8BWtUjQMuDyxjCfXsTZArQemIopSCkXKDhxwVSUM6VK/Q9SFIcWf ez2uIxmJV/FTUQqQ60McrmbdUHb5p+7AcwYH9ebJ0fk2OLkxr6n1ZtYcYK6ENuGBDKErZVFRsbdbO DTQvyOfSOxXBQQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqB4Z-0004hu-IQ; Wed, 02 Nov 2022 06:34:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87o7u228hq.fsf@gnu.org> <87v8o0m809.fsf@gnu.org> Date: Wed, 02 Nov 2022 11:34:13 +0100 In-Reply-To: <87v8o0m809.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 31 Oct 2022 14:34:46 +0100") Message-ID: <87edulwspm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-Guix" Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667385349; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=d6OmjLlbEm3tZ3vkv+xcCGP0Li5+BvXg6nqBcEhxLxA=; b=PsAITr9a3/0Lpu5WwJpuM++jt95HbQFMemUBLKxHf3HFUgfkcGYpiG/cOVvjY0YuXpPyXR Hnis8j225vjZXMB0C1wZsPEFv1aXafx1qnjUXIVW29FkQQonQ4ED/T2kxyJ0it6LbBe6dn ZKeQyWu9XkGGt9JXiPQ35VCVHG3pIAFyt6X75RoYYehFA2usuLtOzUc5b6sFHO+hJIwSmK R6UaJ94yl3fFr6AxxQFNrYf/ATvS8Da26+6QsPBRGvt6LK6/DqokFjzI7maUQTyfR/JLmF NjWFDbcyx0+1rvHclAKyjYgSJD7Q4ghkTLwqRJtZn1oaT2tRTOUhw4hrjBkDgA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667385349; a=rsa-sha256; cv=none; b=KG09xAbOysAUtcKMU3WU5xOB5O35POl3jcH6GGzFUwQOGjumM/lje/3k9api47D8043+T3 OnaG9eNl1TFGNLQSj9EY2v46n5KtQTlz7QM+uszpX+H8jfxRZ90Iejsa8lykJJD60xXyk8 fWTqgNvtMHHvim5RIpS+mUKEmAuIbj0U+jNsHY438ef5jTmvIl9bP2h+rD1R7vTxFs1X8m xWkZGcd1SmIo37GBXei7pvP/M+PdjO68X8qnnacgb1PciLE+dPXAALtCTXsQr5iqB8YNpp Tofzd95SYRkqyI9J5XTuj+BKMwk3i+5AudE4r9lww7YqlZMLAMbx1KDji3c3NQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=l0ZmtrHH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=l0ZmtrHH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A953A11269 X-Spam-Score: -3.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: Ux6/bPrI7j4l Hi, Mathieu Othacehe skribis: >>>From f4d2a1bb4df2f65b650be704bffb7ea469ae0232 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Mon, 31 Oct 2022 13:03:46 +0100 > Subject: [PATCH 1/1] installer: Add core dump support. > > Fixes: > > * gnu/installer.scm (installer-program): Enable core dump generation. > * gnu/installer/dump.scm (%core-dump): New variable. > (prepare-dump): Copy the core dump file. > * gnu/installer/newt/welcome.scm (run-welcome-page): Propose to report an > installation that previously generated a core dump. [...] >>>From d3f2ce83152a8ea453b407652dbee7b86a64816b Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Mon, 31 Oct 2022 16:43:09 +0100 > Subject: [PATCH 1/1] installer: Skip the backtrace page on user abort. > > When the user aborts the installation because a core dump is discovered o= r the > installation command failed, displaying the abort backtrace doesn't make = much > sense. Hide it when the abort condition is &user-abort-error and skip dir= ectly > to the dump page. > > * gnu/installer/steps.scm (&user-abort-error): New variable. > (user-abort-error?): New procedure. > * gnu/installer/newt/final.scm (run-install-failed-page): Raise a > user-abort-error. > * gnu/installer/newt/welcome.scm (run-welcome-page): Ditto. > * gnu/installer.scm (installer-program): Hide the backtrace page and dire= ctly > propose to dump the report when the a &user-abort-error is raised. Both look reasonable to me, thanks! Now, we should probably focus on Guile-Parted=E2=80=A6 Thanks, Ludo=E2=80=99.