bug#23881: System building failure

[ludo@gnu.org (Ludovic Courtès)]

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Kooda <kooda@upyum.com> skribis:
>>
>>> Running `guix system build /etc/config.scm` fails with the following error:
>>>
>>> Backtrace:
> [...]
>>> In guix/scripts/system.scm:
>>>  404: 1 [#<procedure 7a37d50 at guix/scripts/system.scm:390:4 ()>]
>>> In unknown file:
>>>    ?: 0 [string-append "--root=" ...]
>>>
>>> ERROR: In procedure string-append:
>>> ERROR: In procedure string-append: Wrong type (expecting string): #vu8(160 142 87 186 98 117 78 34 144 229 29 155 52 174 54 61)
>
> Fixed by commit c52bf877e9352cd9f29afb13fd4f7d39ed38f1a0.  I'm closing
> this bug, but please re-open it if you believe there's still a problem.
>
>> I cannot reproduce it with current master.
>
> It only happens when one of the *previous* system generations specified
> the root fs by UUID.  I guess this was not the case in your tests.
>
>> Unless I’m mistaken, the problem you report was fixed in
>> f453f637d5410f4d1e0b3787caa8d34b9b72d7d8 in January.
>
> It turns out there was another place that needed fixing:
> 'previous-grub-entries' in (guix scripts system).  When the root device
> of an older generation is specified by UUID, the root device stored in
> ${system}/parameters is a bytevector, and 'boot-parameters-root-device'
> returns a bytevector.  'system->grub-entry' passes this bytevector to
> 'string-append' and that's what's happening in the backtrace above.

Ooh I see, thanks for digging into it!

Ludo’.