From: ludo@gnu.org (Ludovic Courtès)
To: 29335-done@debbugs.gnu.org
Subject: bug#29335: 'guix publish' workers occasionally crash
Date: Sun, 19 Nov 2017 23:48:47 +0100 [thread overview]
Message-ID: <87d14dzxyo.fsf@gnu.org> (raw)
In-Reply-To: <878tf55i6u.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 17 Nov 2017 11:10:49 +0100")
ludo@gnu.org (Ludovic Courtès) skribis:
> On berlin I’ve noticed that the ‘guix publish’ workers would
> occasionally stop working: the main thread would keep replying to HTTP
> requests, but the worker threads would no longer do anything, and would
> leave behind them a bunch of .tmp files in /var/cache/guix/publish.
>
> I captured the output of ‘guix publish’ (guix-0.13.0-8.357ab93) and the
> only clue I have is this:
>
> GET /6kl9ydqmgklcqhxswg6v5isq5n1ih5gp.narinfo
> In guix/workers.scm:
> 74:9 2 (_)
> 78:32 1 (_ srfi-34 #<condition &nix-connection-error [file: "/v…>)
> In unknown file:
> 0 (make-stack #t)
> ERROR: In procedure make-stack:
> ERROR: Throw to key `srfi-34' with args `(#<condition &nix-connection-error [file: "/var/guix/daemon-socket/socket" errno: 9] 3ba2ea0>)'.
> GET /fgiih42mg2sr82mbmzf56grvrf021im6.narinfo
Good news, this is fixed in 85f4f7b79040d982c6a655c898b4cd00d868fa9c.
This could be reproduced by running ‘guix publish’ with 10 workers or
more, and then triggering nar compression en masse with ‘guix weather’.
EBADF was due to a race condition in zlib.scm when closing gzip output
ports:
;; 'gzclose' closes the underlying file descriptor. 'close-port'
;; calls close(2) and gets EBADF, which we swallow.
(gzclose gzfile)
(ignore-EBADF (close-port port)))
There was a window after the ‘gzclose’ call during which the file
descriptor for GZFILE and PORT above could be reused for something else,
and then ‘close-port’ would close it.
Thanks,
Ludo’.
prev parent reply other threads:[~2017-11-19 22:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 10:10 bug#29335: 'guix publish' workers occasionally crash Ludovic Courtès
2017-11-17 12:22 ` Ludovic Courtès
2017-11-17 22:10 ` Ludovic Courtès
2017-11-19 22:48 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d14dzxyo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29335-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).