From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#22608: Module system thread unsafety and .go compilation
Date: Wed, 04 Jul 2018 00:10:10 +0200
Message-ID: <87d0w4ezst.fsf__22061.2563695342$1530655748$gmane$org@gnu.org>
References: <8737t1k5yk.fsf@T420.taylan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1faTVm-0007Ug-Tf
	for bug-guix@gnu.org; Tue, 03 Jul 2018 18:11:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1faTVm-0003Vl-0p
	for bug-guix@gnu.org; Tue, 03 Jul 2018 18:11:02 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:37815)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1faTVl-0003Vb-Sl
	for bug-guix@gnu.org; Tue, 03 Jul 2018 18:11:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1faTVl-00038h-KE
	for bug-guix@gnu.org; Tue, 03 Jul 2018 18:11:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.22608.B22608.153065582311997@debbugs.gnu.org>
In-Reply-To: <8737t1k5yk.fsf@T420.taylan> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Tue, 09 Feb 2016 21:02:27 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: "Taylan Ulrich
	\"=?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=\"" <taylanbayirli@gmail.com>
Cc: 22608@debbugs.gnu.org, guile-devel@gnu.org

Hello,

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis:

> To speed up the compilation of the many Scheme files in Guix, we use a
> script that first loads all modules to be compiled into the Guile
> process (by calling 'resolve-interface' on the module names), and then
> the corresponding Scheme files are compiled in a par-for-each.
>
> While Guile's module system is known to be thread unsafe, the idea was
> that all mutation should happen in the serial loading phase, and the
> parallel compile-file calls should then be thread safe.
>
> Sadly that assumption isn't met when autoloads are involved.

For the record, these issues should be fixed in Guile 2.2.4:

533e3ff17 * Serialize accesses to submodule hash tables.
46bcbfa56 * Module import obarrays are accessed in a critical section.
761cf0fb8 * Make module autoloading thread-safe.

=E2=80=98guix pull=E2=80=99 now defaults to 2.2.4, so we=E2=80=99ll see if =
indeed those crashes
disappear.

Ludo=E2=80=99.