unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: 32770@debbugs.gnu.org
Subject: bug#32770: Packaging SLIME/SWANK as Common Lisp library
Date: Mon, 01 Oct 2018 15:53:50 +0200	[thread overview]
Message-ID: <87d0stwz69.fsf@ambrevar.xyz> (raw)
In-Reply-To: <87k1n2wten.fsf@ambrevar.xyz>

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Another issue, Andy, is with the new `normalize-dependency' function that adds
support for the dependency syntax as specified by the ASDF grammar.  I think
your approach is good but it fails for `jpl-queues` because it produces the
following .asd file in the store:

--8<---------------cut here---------------start------------->8---
(asdf:defsystem
  "jpl-queues"
  :class
  asdf/bundle:prebuilt-system
  :version
  "0.1"
  :depends-on
  ("bordeaux-threads" (:version "jpl-util" "0.2"))
  :components
  ((:compiled-file "jpl-queues--system")))

(progn (asdf/source-registry:ensure-source-registry)
       (setf (gethash
               "bordeaux-threads"
               asdf/source-registry:*source-registry*)
             #p
             "/gnu/store/67dhvxva7345r2xijz9yqp94s0fslrpn-sbcl-bordeaux-threads-0.8.5-1.354abb0/share/common-lisp/sbcl-bundle-systems/bordeaux-threads.asd"))
--8<---------------cut here---------------end--------------->8---

Note that jpl-util is missing from the registry link list.

It turns out that it fails because the match-lambda you've used to implement the
standard are case-sensitive, while the standard is case-insensitive.

Adn... jpl-queues uses ":VERSION" and not ":version" as you expected :(

I think the simple fix would be to make the two match-lambda case-insensitive
(both in generate-dependency-links and in make-asd-file).

What do you think?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2018-10-01 13:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19  7:19 bug#32770: Packaging SLIME/SWANK as Common Lisp library Pierre Neidhardt
2018-09-29 19:16 ` Andy Patterson
2018-09-30 21:27   ` Pierre Neidhardt
2018-09-30 21:46     ` Pierre Neidhardt
2018-10-01 13:53       ` Pierre Neidhardt [this message]
2018-10-02  8:38         ` Andy Patterson
2018-10-02  8:55       ` Andy Patterson
2018-10-02 10:24         ` Pierre Neidhardt
2018-10-03  5:22           ` Andy Patterson
2018-10-03 18:34             ` Pierre Neidhardt
2018-10-03 19:48               ` Pierre Neidhardt
2018-10-04  5:03               ` Andy Patterson
2018-10-04  8:37                 ` Pierre Neidhardt
2018-10-04 18:08                   ` Ricardo Wurmus
2018-10-04 20:38                     ` Pierre Neidhardt
2019-10-06 11:53                       ` Pierre Neidhardt
2018-10-05  4:56                   ` Andy Patterson
2018-10-05  8:28                     ` Pierre Neidhardt
2018-10-05 11:44                       ` Ricardo Wurmus
2018-10-05 13:30                         ` Pierre Neidhardt
2018-10-10  5:54                           ` Andy Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0stwz69.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=32770@debbugs.gnu.org \
    --cc=ajpatter@uwaterloo.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).