unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 宋文武 <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org, 34407-done@debbugs.gnu.org
Subject: bug#34407: [PATCH] shepherd: Delete the socket file upon exit.
Date: Mon, 08 Apr 2019 10:58:57 +0200	[thread overview]
Message-ID: <87d0lw27qm.fsf__31512.1179375396$1554714034$gmane$org@gnu.org> (raw)
In-Reply-To: <87ef87w0d3.fsf@member.fsf.org> ("宋文武"'s message of "Sun, 17 Feb 2019 11:38:16 +0800")

Hello,

iyzsong@member.fsf.org (宋文武) skribis:

> Yes, I have the 'rm /run/user/1000/shepherd/socket' workaround in my session
> script too...

I never had to do that because /run is wiped at boot time, like Danny
wrote.

> According to 'man 2 bind', the socket pathname should be deleted when no
> longer required, so a patch to fix this bug:
>
> From f171f6adb2fc6ee3bf4d25378c2e7bba109b43d8 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
> Date: Sun, 17 Feb 2019 11:27:28 +0800
> Subject: [PATCH] shepherd: Delete the socket file upon exit.
>
> Fixes <https://bugs.gnu.org/34407>.
>
> * modules/shepherd.scm (call-with-server-socket): New procedure.
> (main): Use it instead of 'open-server-socket'.

Pushed, thanks!

Ludo’.

      parent reply	other threads:[~2019-04-08  9:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 19:56 bug#34407: Shepherd won't close socket on exit nly
2019-02-09 20:21 ` bug#34407: Acknowledgement (Shepherd won't close socket on exit) nly
2019-02-13 23:05   ` Maxim Cournoyer
2019-02-17  3:38 ` bug#34407: [PATCH] shepherd: Delete the socket file upon exit 宋文武
     [not found] ` <87ef87w0d3.fsf@member.fsf.org>
2019-02-19 19:08   ` Danny Milosavljevic
     [not found]   ` <20190219200900.12407d94@scratchpost.org>
2019-02-23  8:53     ` 宋文武
2019-04-08  8:58   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87d0lw27qm.fsf__31512.1179375396$1554714034$gmane$org@gnu.org' \
    --to=ludo@gnu.org \
    --cc=34407-done@debbugs.gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).