From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: bug#39699: [core-updates] gash-boot0 fails on i686-linux Date: Fri, 21 Feb 2020 22:30:43 +0100 Message-ID: <87d0a78w70.fsf@gnu.org> References: <87y2sx41f2.fsf@devup.no> <87zhdc9b1e.fsf@gnu.org> <87mu9c81z9.fsf@gnu.org> <87h7zj3cc3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:33849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5Ft2-0008Au-8h for bug-guix@gnu.org; Fri, 21 Feb 2020 16:31:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5Ft1-00048v-6r for bug-guix@gnu.org; Fri, 21 Feb 2020 16:31:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42282) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5Ft1-00048p-42 for bug-guix@gnu.org; Fri, 21 Feb 2020 16:31:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5Ft1-00061t-1y for bug-guix@gnu.org; Fri, 21 Feb 2020 16:31:03 -0500 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-Reply-To: <87h7zj3cc3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 21 Feb 2020 21:38:36 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39699-done@debbugs.gnu.org Ludovic Court=C3=A8s writes: Hi! >> I would prefer 3., with the fix going upstream. This opens the path to >> really using bzip2 in the bootstrap. 2. could be a nice intermediate >> step, but I would not know how to do that nicely, as we fetch >> (compression bzip2) from upstream. Timothy? > > I don=E2=80=99t think we=E2=80=99ll introduce new uses of bzip2 on the bo= otstrap path. > So if it=E2=80=99s unnecessary today, it may remain unnecessary in the > foreseeable future. That's a helpful perspective; Yes, I agree. >> See #39699 > > Nitpick: =E2=80=9CFixes .=E2=80=9D :-) Thanks. >> (chdir "bootar") >> + (when ,(equal? (%current-system) "i686-linux") >> + (delete-file "scripts/bzip2.in") >> + (delete-file "compression/bzip2.scm") >> + (with-output-to-file "compression/bzip2.scm" >> + (lambda _ >> + (display "(define-module (compression bzip2)) >> +(define-public is-bzip2-file? (const #f)) >> +(define-public make-bzip2-input-port (const #f)) >> +")))) > > Perhaps you can write it in a way that avoids rebuilds on x86_64: > > ,@(if (equal? =E2=80=A6) > '((=E2=80=A6)) > '()) Neat... > Or actually, we can just remove the functionality unconditionally for > now since it could be error-prone to have different features depending > on the platform. > > WDYT? Yes, I removed it. Hoping that's okay. We just decided above it's adding an unnecessary "if". @Timothy: if you want to change this in bootar itself and remove the workaround from commencement, please feel free. Pushed to core-updates as a82cf70e8ae4c8dcf03d2633f09dcfc8bb6d6d1e Thanks, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com