bug#40650: guix test suite failures building Debian package

["Ludovic Courtès" <ludo@gnu.org>]

Hi Vagrant,

Vagrant Cascadian <vagrant@debian.org> skribis:

> Any of the test suites that require networking will need to be disabled
> for Debian packages.

That should be fine.

> One thing that occurs to me is Debian systems have USER_NS_UNPRIVLEDGED
> disabled by default (enableable at run-time with
> /proc/sys/kernel/unprivileged_userns_clone).

That should be fine too: tests that rely on unprivileged user namespaces
are skipped when that’s missing.

> Attached is the test-suite.log, as requested.

Excellent!

> test-name: wrap-program, one input, multiple calls
> location: /build/guix-jgTHmh/guix-1.1.0/tests/build-utils.scm:94
> source:
> + (test-equal
> +   "wrap-program, one input, multiple calls"
> +   "hello world\n"
> +   (call-with-temporary-directory
> +     (lambda (directory)
> +       (let ((bash (search-bootstrap-binary
> +                     "bash"
> +                     (%current-system)))
> +             (foo (string-append directory "/foo")))
> +         (call-with-output-file
> +           foo
> +           (lambda (p)
> +             (format
> +               p
> +               "#!~a~%echo \"${GUIX_FOO} ${GUIX_BAR}\"~%"
> +               bash)))
> +         (chmod foo 511)
> +         (with-environment-variable
> +           "PATH"
> +           (dirname bash)
> +           (wrap-program foo `("GUIX_FOO" prefix ("hello")))
> +           (wrap-program foo `("GUIX_BAR" prefix ("world")))
> +           (unsetenv "LOCPATH")
> +           (let* ((pipe (open-input-pipe foo))
> +                  (str (get-string-all pipe)))
> +             (with-directory-excursion
> +               directory
> +               (for-each delete-file '("foo" ".foo-real")))
> +             (and (zero? (close-pipe pipe)) str)))))))
> expected-value: "hello world\n"
> actual-value: #f
> actual-error:
> + (system-error
> +   "copy-file"
> +   "~A: ~S"
> +   ("Permission denied"
> +    "/build/guix-jgTHmh/guix-1.1.0/gnu/packages/bootstrap/i686-linux/bash")
> +   (13))
> result: FAIL

Here’s it’s ‘search-bootstrap-binary’ from (guix tests) that tries to
create the file above, having downloaded it earlier.

For the ‘guix’ package in Guix, what we do is that this and related
files are inputs to the package; that way, they are not downloaded at
all upon ‘make check’ since they’re already there.

All you need is to ensure that
gnu/packages/bootstrap/*-linux/{bash,mkdir,tar,xz} exist, are
executable, and are statically-linked.  You could provide Debian
binaries if that’s more appropriate.

> test-name: channel-instances->manifest
> location: /build/guix-jgTHmh/guix-1.1.0/tests/channels.scm:177

[...]

> +                Initialized empty Git repository in /tmp/guix-directory.kYfBE0/.git/
>
> *** Please tell me who you are.
>
> Run
>
>   git config --global user.email "you@example.com"
>   git config --global user.name "Your Name"
>
> to set your account's default identity.
> Omit --global to set the identity only in this repository.
>
> fatal: unable to auto-detect email address (got 'vagrant@yucca.(none)')

We may need to provide a dummy .gitconfig file or something here so we
can run these tests.  See also <https://issues.guix.gnu.org/issue/37679>.
(The same applies to several test failures.)

Thoughts?

> test-name: scandir*, properties
> location: /build/guix-jgTHmh/guix-1.1.0/tests/syscalls.scm:257
> source:
> + (test-assert
> +   "scandir*, properties"
> +   (let ((directory
> +           (dirname
> +             (search-path %load-path "guix/base32.scm"))))
> +     (every (lambda (entry name)
> +              (match entry
> +                     ((name2 . properties)
> +                      (and (string=? name2 name)
> +                           (let* ((full (string-append directory "/" name))
> +                                  (stat (lstat full))
> +                                  (inode (assoc-ref properties 'inode))
> +                                  (type (assoc-ref properties 'type)))
> +                             (and (= inode (stat:ino stat))
> +                                  (or (eq? type 'unknown)
> +                                      (eq? type (stat:type stat)))))))))
> +            (scandir* directory)
> +            (scandir directory (const #t) string<?))))
> actual-value: #f
> result: FAIL

Could you wrap the ‘scandir*’ and ‘scandir’ calls in ‘pk’, run:

  make check TESTS=tests/syscalls.scm

and send ‘test-suite.log’?

> ++ guix build guile-gcrypt --with-branch=guile-gcrypt=master -d
> accepted connection from pid 17231, user vagrant
> updating checkout of 'https://notabug.org/cwebber/guile-gcrypt.git'...
> guix build: error: cannot fetch branch 'master' from https://notabug.org/cwebber/guile-gcrypt.git: the SSL certificate is invalid: 0x08 - The certificate is not correctly signed by the trusted CA
> + latest_drv=
> FAIL tests/guix-build-branch.sh (exit status: 1)

This test relies on network access + HTTPS certificates.  It does check
for the former but not the latter.  Any suggestions on how to do that?

Thanks,
Ludo’.