From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SOT7DsgpYV8yDQAA0tVLHw (envelope-from ) for ; Tue, 15 Sep 2020 20:53:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oGk4CcgpYV9HXQAAbx9fmQ (envelope-from ) for ; Tue, 15 Sep 2020 20:53:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B52229402DA for ; Tue, 15 Sep 2020 20:53:27 +0000 (UTC) Received: from localhost ([::1]:36658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIHx7-0005KR-NL for larch@yhetil.org; Tue, 15 Sep 2020 16:53:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIHtq-0002Wq-03 for bug-guix@gnu.org; Tue, 15 Sep 2020 16:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIHtp-00062s-KK for bug-guix@gnu.org; Tue, 15 Sep 2020 16:50:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIHtp-00031Z-HE for bug-guix@gnu.org; Tue, 15 Sep 2020 16:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 15 Sep 2020 20:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43232 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner , Mike Rosset Received: via spool by 43232-submit@debbugs.gnu.org id=B43232.160020298211590 (code B ref 43232); Tue, 15 Sep 2020 20:50:01 +0000 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 20:49:42 +0000 Received: from localhost ([127.0.0.1]:60678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHtV-00030s-PT for submit@debbugs.gnu.org; Tue, 15 Sep 2020 16:49:41 -0400 Received: from world.peace.net ([64.112.178.59]:42082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHtU-00030b-FG for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 16:49:40 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIHtO-0000C1-9R; Tue, 15 Sep 2020 16:49:34 -0400 From: Mark H Weaver In-Reply-To: <87ft7ibwpz.fsf@netris.org> References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> Date: Tue, 15 Sep 2020 16:48:17 -0400 Message-ID: <87d02mbwb7.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43232@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: ywa+kv9e6nwX Earlier, I wrote: > In contrast, a call to 'substitute*' will silently start doing nothing, > and may easily be forgotten. To make matters worse, a future version of > jack-2 might add another 'for' loop in that file, matching the same > pattern but where it is important that 'i' _not_ be initialized to 0. Sorry, I made a mistake in the details here, since the pattern applies only when 'i' is already initialized to 0, but the more general point still stands, namely that patches are more robust than 'substitute*' for fixing bugs, and less likely to be misapplied or left forgotten in a vestigial state after they are no longer needed. Mark