unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36504: asdf build system: Add support for component-less .asd
@ 2019-07-04 17:33 Pierre Neidhardt
  2020-11-29 15:10 ` Guillaume Le Vaillant
  0 siblings, 1 reply; 2+ messages in thread
From: Pierre Neidhardt @ 2019-07-04 17:33 UTC (permalink / raw)
  To: 36504; +Cc: Katherine Cox-Buday

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

I've just packaged sbcl-trivia (hooray!), which implied packaging the
component-less trivia.trivial subsystem.

If you look at the package definition, I had to do this in order to
compile successfully:

--8<---------------cut here---------------start------------->8---
(replace 'create-asd-file
           (lambda* (#:key outputs inputs #:allow-other-keys)
             (let* ((out (assoc-ref outputs "out"))
                    (lib (string-append out "/lib/sbcl"))
                    (level2 (assoc-ref inputs "trivia.level2")))
               (mkdir-p lib)
               (install-file "trivia.trivial.asd" lib)
               ;; XXX: This .asd does not have any component and the build
               ;; system fails to work in this case.  We should update the
               ;; build system to handle component-less .asd.
               ;; TODO: How do we append to file in Guile?  It seems that
               ;; (open-file ... "a") gets a "Permission denied".
               (substitute* (string-append lib "/trivia.trivial.asd")
                 (("\"\\)")
                  (string-append "\")

(progn (asdf/source-registry:ensure-source-registry)
       (setf (gethash
               \"trivia.level2\"
               asdf/source-registry:*source-registry*)
             #p\""
                                 level2
                                 "/share/common-lisp/sbcl-bundle-systems/trivia.level2.asd\"))"))))))
--8<---------------cut here---------------end--------------->8---

Basically our build system fails when the .asd has no component, which
is done sometime in Common Lisp packages where a system is only used as an
indirection of a union of other systems.

I suggest we update `make-asd-file' file in `lisp-utils.scm' to take
that into account.

Thoughts?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#36504: asdf build system: Add support for component-less .asd
  2019-07-04 17:33 bug#36504: asdf build system: Add support for component-less .asd Pierre Neidhardt
@ 2020-11-29 15:10 ` Guillaume Le Vaillant
  0 siblings, 0 replies; 2+ messages in thread
From: Guillaume Le Vaillant @ 2020-11-29 15:10 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: 36504-done

[-- Attachment #1: Type: text/plain, Size: 90 bytes --]


This is now fixed in the master branch (since
4dadb4977908028bb0651d43ed4813cc988db92d).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-29 15:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-04 17:33 bug#36504: asdf build system: Add support for component-less .asd Pierre Neidhardt
2020-11-29 15:10 ` Guillaume Le Vaillant

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).