From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yFYuIeuvGmIUGwAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 23:55:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YE11HuuvGmLFIgAA9RJhRA (envelope-from ) for ; Sat, 26 Feb 2022 23:55:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 307F0309E0 for ; Sat, 26 Feb 2022 23:55:39 +0100 (CET) Received: from localhost ([::1]:59876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nO5yT-0000BO-Lh for larch@yhetil.org; Sat, 26 Feb 2022 17:55:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nO5xu-0000Ay-4e for bug-guix@gnu.org; Sat, 26 Feb 2022 17:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nO5xt-0000IX-RO for bug-guix@gnu.org; Sat, 26 Feb 2022 17:55:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nO5xt-000489-QH for bug-guix@gnu.org; Sat, 26 Feb 2022 17:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51460: emacs-magit: path error during commit Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Feb 2022 22:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51460 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Christopher Howard Received: via spool by 51460-submit@debbugs.gnu.org id=B51460.164591607615830 (code B ref 51460); Sat, 26 Feb 2022 22:55:01 +0000 Received: (at 51460) by debbugs.gnu.org; 26 Feb 2022 22:54:36 +0000 Received: from localhost ([127.0.0.1]:56441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO5xU-00047G-0Z for submit@debbugs.gnu.org; Sat, 26 Feb 2022 17:54:36 -0500 Received: from out0.migadu.com ([94.23.1.103]:44788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO5xR-000477-O7 for 51460@debbugs.gnu.org; Sat, 26 Feb 2022 17:54:34 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1645916071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DnLLOoJsbvVlNO0dxDIM2npdr/cxNjAcDXnpjUZuz0Y=; b=uhAflTM0JhtkzMn5jUuSkqyfg589u5qjYe5dGW87y9fB+O9APhzAjKFZcZsBcWocK3bcBB ie+bMqpvlcM+sSq9hhRwWNECU4o8inSR/Ww/yGxtch3oo6eUIFDuqVB8DnfAA0dQa09Kcm w/8OVK4sBewoZArShuQ/KwMd+waRMtww4CmiRLu3vnlEvloD73n08QQKMEg7Kxo8RoTsAT El8I/j8E75PaUwM2cUmDvdleyKe+U6CM1lJ+8k4952joZqL71QsgWTIZQGb5kWXiGX3A5t JzlLKu648YZH1U76Ws4w83/pTBLMCMRFXv0dxSl2rI5/1bZBv6ILLTs9Zefe5w== From: Kyle Meyer In-Reply-To: <068232bf9c2157d6b8636615b361398cac4470c1.camel@librehacker.com> References: <068232bf9c2157d6b8636615b361398cac4470c1.camel@librehacker.com> Date: Sat, 26 Feb 2022 17:54:29 -0500 Message-ID: <87czj92q8q.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 51460@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645916139; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DnLLOoJsbvVlNO0dxDIM2npdr/cxNjAcDXnpjUZuz0Y=; b=QAzpuWHs27kFbPQSg94a2Qy4CNPCpBrBU2uYBhsZc0prD9jSXJZpxVycIq3Kh2hWkg82Cq kjkaHg0sAeKZ/70EKiObkfy10QDWIce44f6oEddY/6Jb7z4uWmM6t0ft+ls2Rh4pI/funy N5nbSlj29mAYyYen092VhE087DTBqef+0rS6QwPex9OQZ5rUJWIcUbnYUvHoO3UsUBEzh2 G6quYxt6RRx/aZTf9b/h5zqaHGjZrVvbYYMJatpKwBTYzNQ0PZbeZ7gp6cTKCT8/q+Vv+h d9Kb+RVHyB6o0DWgqK6epuUVeuO5yqxknS2b4plI7omhCZgnYr/wlPIUE9Jldg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645916139; a=rsa-sha256; cv=none; b=SmxgM6EbgFLO1uXAX/zxckdf5p+P0Ij3M0NSgXrCRlPyH7pWo8pIvFg0D40nOdcwmZxn45 Qkk9A1w7OGAIUH5BrsVybz4OMn0MYzdLzj9aN34GsVegcMfggNtmRSvllf2+/fFc4xwdDY YnRiWtQIJa8DQCC4po0nGvHKM10eiHyH3LPjMUBixDOH0rL3wsVq28ACdlKQp9bqxuJ2iH IjiCZlvgJDhyaVk6J8LdcGr5lP8O6jGsfCRXb+3PXUrWac8M5ILsYtFnf32r0MhvqCKUin qFjKSYxqzUmhQPgH97xbqNoxpf9CoXs+lzVyRfEVfWP+QvEaZCLj3NxbjsnMQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=uhAflTM0; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=uhAflTM0; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 307F0309E0 X-Spam-Score: -0.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: NO7QzqjbOeO/ Hello, I came across this bug report when searching for something else. In case it helps... Christopher Howard writes: > Hello, for a long time I've struggled with getting a path error when I > try to do a commit using emacs-magit. Here is an example log copied from > the magit-process buffer: > > ``` > 0 git =E2=80=A6 add -u -- Genesis/gen_1.org > 1 git =E2=80=A6 commit -- > hint: Waiting for your editor to close the file... > Waiting for Emacs... > *ERROR*: Searching for program: No such file or directory, git > error: There was a problem with the editor > '/gnu/store/dpky3z5844bclhswdk69z90vayy65b58-emacs-27.2/bin/emacsclient > --socket-name=3D/run/user/1000/emacs/server'. > Please supply the message using either -m or -F option. > ``` In Magit v3.3.0 and earlier, this error matches what you would see if "git" isn't in $PATH for the editor that pops up. This is true even when magit-git-executable points to an executable. In the development version of Magit, this should no longer happen as of 77255776 (git-commit: Use magit-git-executable function if available, 2022-02-21). The issue that prompted that is . (I know that below you say you don't use GitHub, but for others that may find that useful.) (Based on what you say below, it sounds like "git" should be in $PATH, so things aren't quite adding up still.) > I find this confusing because > - I can use magit to stage my commits > - In the Magit Group (M-x customize-group magit), the Magit Git > Executable is set to /home/christopher/.guix-profile/bin/git, and that > file does exist in my profile. > - /gnu/store/dpky3z5844bclhswdk69z90vayy65b58-emacs-27.2/bin/emacsclient= =20 > also does exist Yes, staging and most of things in Magit respect magit-git-executable. As I mention above and you suspect in the quoted text below, that value wasn't consulted by the code path relevant for the error above (in git-commit.el). > - Within emacs, I can run the shell command M-! git commit or M-! git > commit -m "..." and this works fine. Hmm, so your main Emacs session has "git" on its exec-path. Perhaps there's something going on with the with-editor launched editor. I'd suggest looking at with-editor-debug and seeing if /home/christopher/.guix-profile/bin is in the path it reports. > I suspect that emacs-magit might not be properly using the Magit Git > Executable path for this action, but haven't had a chance to look at the > source code yet. Yep, that's it, and, as I mentioned above, should be fixed by 77255776 (git-commit: Use magit-git-executable function if available, 2022-02-21).