From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id APDWKSiTQGMWcAAAbAwnHQ (envelope-from ) for ; Fri, 07 Oct 2022 22:59:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sDm/KSiTQGPwVgAAauVa8A (envelope-from ) for ; Fri, 07 Oct 2022 22:59:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A3E85329 for ; Fri, 7 Oct 2022 22:59:20 +0200 (CEST) Received: from localhost ([::1]:51750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oguRD-0007EY-FR for larch@yhetil.org; Fri, 07 Oct 2022 16:59:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oguQy-0007EL-7B for bug-guix@gnu.org; Fri, 07 Oct 2022 16:59:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38488) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oguQw-0003r9-9h for bug-guix@gnu.org; Fri, 07 Oct 2022 16:59:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oguQw-000453-2c for bug-guix@gnu.org; Fri, 07 Oct 2022 16:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 07 Oct 2022 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30265 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: John Soo , Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 30265@debbugs.gnu.org Received: via spool by 30265-submit@debbugs.gnu.org id=B30265.166517633615674 (code B ref 30265); Fri, 07 Oct 2022 20:59:02 +0000 Received: (at 30265) by debbugs.gnu.org; 7 Oct 2022 20:58:56 +0000 Received: from localhost ([127.0.0.1]:37566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguQp-00044k-VS for submit@debbugs.gnu.org; Fri, 07 Oct 2022 16:58:56 -0400 Received: from world.peace.net ([64.112.178.59]:35094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oguQn-00044V-C3 for 30265@debbugs.gnu.org; Fri, 07 Oct 2022 16:58:53 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oguQh-0001Hl-8a; Fri, 07 Oct 2022 16:58:47 -0400 From: Mark H Weaver In-Reply-To: References: <87inbnpsx9.fsf@gmail.com> <8B84EF65-4CCC-4CAF-A6E9-BF6F5566D11E@asu.edu> <871qrj5sj9.fsf@gmail.com> Date: Fri, 07 Oct 2022 16:57:43 -0400 Message-ID: <87czb3uza5.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665176360; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=pNNyPJsZhqgIMSTra0nAUzOPcaQzYgbPeunjBM2GvmA=; b=RCm0rkI/ZYpOhhDkFiOesAPyHDSHEVxhHRgje9Viq2GU6DYMMoGovIlc9vtTWOwQ4u4X1R GQLHDd3s6BxdmS6KWchltVaGUBL7PC8DZC/CDvHD1OPcX0exALaMgbh9rdgrjm9QroX1Ao G1+dQhjA06Nf3ueQ8gYfTaTqbg44RHrJJJwUqq0qhHF7nMIkhaPT8uXNwFnD8wjEsLSHEY 3OQcicvFSOAH7evOHon5y3rjslHytD5BQCC6JLoPDMdxiZ0uuneGAUpNDCU8LAxUaR/dYC hkWCa//FvIZxbF56dasJIvNbsIhGe7H82WLXGd18MBb05QyxIlGUYVBLb8iEWw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665176360; a=rsa-sha256; cv=none; b=HhBSbw7lAOD/O16XlXLLJwMiPf1RwK+UuI6pyrCl/YUsxXXIwSLdfo7GIvY/mqaQQWjtgB i8+eRDUyOy8kL4rr0SxAL5L1dDeEOSw5E3WPgZW/MOm9LTJtV6/l/5pqTDXF7obI3qpS2z I+Y1P+ukmVTXThPR2j6LdZzldyGeF/hzYp6/Jx+yDu9S1l9GoNIygiOd6xXklXpjQf4QXX pQ2vb7txwFMe6n48XO971gi2s1CfdRxTe+QXs0yJ69ea2GYvcNsQimFAHJVnTlKdHbJVBF LWdjvUSiR2aOhDIJfpbiYoNQUeJB1hkdk4BzqM3Oku2CvYYivJLpXJX+ih1JXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4A3E85329 X-Spam-Score: -1.87 X-Migadu-Scanner: scn0.migadu.com X-TUID: IDe4du1e9d8z John Soo writes: > I looked into it and I think a patch to fish might be required but I > got buried in other work. Note that commit 1bab9b9f17256a9e4f45f5b0cceb8b52e0a1b1ed (April 2021) added support in our grafting code to find and rewrite UTF-16 and UTF-32 store references. That might have mitigated or even eliminated the adverse effects of this bug. However, the Guix daemon's reference scanner still does not detect UTF-16/32 references. This could be a problem if some store item is reachable *only* via UTF-16/32 store references, because "guix gc" might delete it even though it is still needed. However, if it is the case that every referenced store item is represented in ASCII or UTF-8 at least once, everything should work. Therefore, an easy workaround would be to add another phase that simply creates a file in the output(s) that contains ASCII or UTF-8 references to any needed store items. Mark -- Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about .